Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1291983003: Add user_regs_struct and user_fpsimd_struct for aarch64 on Android. (Closed)

Created:
5 years, 4 months ago by rmcilroy
Modified:
5 years, 4 months ago
CC:
google-breakpad-dev_googlegroups.com
Target Ref:
refs/remotes/origin/master
Visibility:
Public.

Description

Add user_regs_struct and user_fpsimd_struct for aarch64 on Android. Android's sys/user.h is missing user_regs_struct and user_fpsimd_struct. Add them to the Android specific user.h used by breakpad to workaround Android / glibc compatibility issues. A bug has been filed on the Android NDK team to add the missing structures to the NDK, at which point this hack can be removed. Also remove the mxcsr_mask hack on x64, which is no longer required since we have moved to the r10d NDK which fixes this issue. R=primiano@chromium.org Committed: https://code.google.com/p/google-breakpad/source/detail?r=1495

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add extern c #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -18 lines) Patch
M src/common/android/include/sys/user.h View 1 2 chunks +23 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmcilroy
Primiano, could you take a look please?
5 years, 4 months ago (2015-08-20 14:10:49 UTC) #2
Primiano Tucci (use gerrit)
Many thanks for the fix. LGTM with 1 question. I can re-roll after you land ...
5 years, 4 months ago (2015-08-20 14:25:09 UTC) #3
rmcilroy
https://codereview.chromium.org/1291983003/diff/1/src/common/android/include/sys/user.h File src/common/android/include/sys/user.h (right): https://codereview.chromium.org/1291983003/diff/1/src/common/android/include/sys/user.h#newcode56 src/common/android/include/sys/user.h:56: struct user_regs_struct { On 2015/08/20 14:25:09, Primiano Tucci wrote: ...
5 years, 4 months ago (2015-08-20 14:29:03 UTC) #4
rmcilroy
5 years, 4 months ago (2015-08-20 14:30:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 1495 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698