Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 1291973002: [runtime] Remove useless DELETE builtin. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove useless DELETE builtin. The DELETE builtin calls through to %DeleteProperty anyway, so we can as well skip the builtin completely and always call into the runtime directly. Also add different entries depending on whether calling code is in sloppy or strict/strong mode. R=yangguo@chromium.org Committed: https://crrev.com/3d01d31fa94f7cda711c12735cb69a1fe795cc8d Cr-Commit-Position: refs/heads/master@{#30148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -67 lines) Patch
M src/builtins.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M src/runtime.js View 2 chunks +0 lines, -7 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 2 chunks +30 lines, -6 lines 0 comments Download
M src/v8natives.js View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 4 months ago (2015-08-13 08:51:21 UTC) #1
Benedikt Meurer
Hey Yang, Moar cleanup to the builtins. Please take a look. Thanks, Benedikt
5 years, 4 months ago (2015-08-13 08:52:58 UTC) #2
Yang
On 2015/08/13 08:52:58, Benedikt Meurer wrote: > Hey Yang, > > Moar cleanup to the ...
5 years, 4 months ago (2015-08-13 09:23:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291973002/1
5 years, 4 months ago (2015-08-13 09:39:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 09:41:40 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 09:42:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d01d31fa94f7cda711c12735cb69a1fe795cc8d
Cr-Commit-Position: refs/heads/master@{#30148}

Powered by Google App Engine
This is Rietveld 408576698