Issue 129193002: Revert of chromeos: Don't send empty power management policies.

Issue 129193002: Revert of chromeos: Don't send empty power management policies. (Closed)

Created:
6 years, 11 months ago by Noam Samuel

Modified:
6 years, 11 months ago

Reviewers:
bartfab (slow), benwells, Daniel Erat

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of https://codereview.chromium.org/116983008/ Reason for revert: ChromeOS bot failures on x86/amd64 TBR=bartfab@chromium.org,benwells@chromium.org,derat@chromium.org NOTREECHECKS=true NOTRY=true BUG=329930 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243634

Patch Set 1 #

Created: 6 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+105 lines, -83 lines)			Patch
M	chrome/browser/apps/app_browsertest.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/policy/power_policy_browsertest.cc	View	4 chunks	+16 lines, -15 lines	0 comments	Download
M	chrome/browser/chromeos/power/power_prefs.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/power/power_prefs_unittest.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc	View	6 chunks	+8 lines, -8 lines	0 comments	Download
M	chromeos/dbus/fake_power_manager_client.h	View	3 chunks	+10 lines, -20 lines	0 comments	Download
M	chromeos/dbus/fake_power_manager_client.cc	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	chromeos/dbus/power_policy_controller.h	View	5 chunks	+15 lines, -2 lines	0 comments	Download
M	chromeos/dbus/power_policy_controller.cc	View	4 chunks	+32 lines, -6 lines	0 comments	Download
M	chromeos/dbus/power_policy_controller_unittest.cc	View	8 chunks	+10 lines, -18 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Noam Samuel

Created Revert of chromeos: Don't send empty power management policies.

6 years, 11 months ago (2014-01-08 20:00:31 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/129193002/1

6 years, 11 months ago (2014-01-08 20:02:05 UTC) #2

Noam Samuel

6 years, 11 months ago (2014-01-08 22:08:13 UTC) #5

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/129303003/ by noamsml@chromium.org.

The reason for reverting is: Did not fix chromeos failures.

Expand Messages | Collapse Messages