Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1446)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 1291903003: Oilpan: Move ChromeClient classes into Oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Make Page::PageClients STACK_ALLOCATED(). Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/web/InspectorOverlayImpl.cpp ('K') | « Source/web/WebViewImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 6eb50580c2bf29e160f74b222c7187075b105a8d..919dda1655fc849c62d7e7c0896d5dd627fecc47 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -412,7 +412,7 @@ HashSet<WebViewImpl*>& WebViewImpl::allInstances()
WebViewImpl::WebViewImpl(WebViewClient* client)
: m_client(client)
, m_spellCheckClient(0)
- , m_chromeClientImpl(this)
+ , m_chromeClientImpl(ChromeClientImpl::create(this))
, m_contextMenuClientImpl(this)
, m_dragClientImpl(this)
, m_editorClientImpl(this)
@@ -460,7 +460,7 @@ WebViewImpl::WebViewImpl(WebViewClient* client)
, m_elasticOverscroll(FloatSize())
{
Page::PageClients pageClients;
- pageClients.chromeClient = &m_chromeClientImpl;
+ pageClients.chromeClient = m_chromeClientImpl.get();
pageClients.contextMenuClient = &m_contextMenuClientImpl;
pageClients.editorClient = &m_editorClientImpl;
pageClients.dragClient = &m_dragClientImpl;
« Source/web/InspectorOverlayImpl.cpp ('K') | « Source/web/WebViewImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698