Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: Source/core/testing/DummyPageHolder.cpp

Issue 1291903003: Oilpan: Move ChromeClient classes into Oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix a raw reference in InspectorOverlayImpl.cpp. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/testing/DummyPageHolder.h ('k') | Source/platform/HostWindow.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/testing/DummyPageHolder.cpp
diff --git a/Source/core/testing/DummyPageHolder.cpp b/Source/core/testing/DummyPageHolder.cpp
index 533a3544c6d180c62bb2c074a15360aef753ac04..733e19c402e883566e01f2cfbb38a4212684bc05 100644
--- a/Source/core/testing/DummyPageHolder.cpp
+++ b/Source/core/testing/DummyPageHolder.cpp
@@ -49,19 +49,20 @@ PassOwnPtr<DummyPageHolder> DummyPageHolder::create(
DummyPageHolder::DummyPageHolder(
const IntSize& initialViewSize,
- Page::PageClients* pageClients,
+ Page::PageClients* pageClientsArgument,
PassOwnPtr<FrameLoaderClient> frameLoaderClient)
{
- if (!pageClients) {
- fillWithEmptyClients(m_pageClients);
+ Page::PageClients pageClients;
+ if (!pageClientsArgument) {
+ fillWithEmptyClients(pageClients);
} else {
- m_pageClients.chromeClient = pageClients->chromeClient;
- m_pageClients.contextMenuClient = pageClients->contextMenuClient;
- m_pageClients.editorClient = pageClients->editorClient;
- m_pageClients.dragClient = pageClients->dragClient;
- m_pageClients.spellCheckerClient = pageClients->spellCheckerClient;
+ pageClients.chromeClient = pageClientsArgument->chromeClient;
+ pageClients.contextMenuClient = pageClientsArgument->contextMenuClient;
+ pageClients.editorClient = pageClientsArgument->editorClient;
+ pageClients.dragClient = pageClientsArgument->dragClient;
+ pageClients.spellCheckerClient = pageClientsArgument->spellCheckerClient;
}
- m_page = adoptPtrWillBeNoop(new Page(m_pageClients));
+ m_page = adoptPtrWillBeNoop(new Page(pageClients));
Settings& settings = m_page->settings();
// FIXME: http://crbug.com/363843. This needs to find a better way to
// not create graphics layers.
« no previous file with comments | « Source/core/testing/DummyPageHolder.h ('k') | Source/platform/HostWindow.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698