Source/core/loader/EmptyClients.cpp - Issue 1291903003: Oilpan: Move ChromeClient classes into Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/EmptyClients.cpp

Issue 1291903003: Oilpan: Move ChromeClient classes into Oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/EmptyClients.cpp

diff --git a/Source/core/loader/EmptyClients.cpp b/Source/core/loader/EmptyClients.cpp

index 597dd4306bb947e63c5ef782cdaffddc9c02875e..ad8a00f689bc151f1b980bd899112af3a5b58d44 100644

--- a/Source/core/loader/EmptyClients.cpp

+++ b/Source/core/loader/EmptyClients.cpp

@@ -45,7 +45,7 @@ namespace blink {

void fillWithEmptyClients(Page::PageClients& pageClients)

{

- static ChromeClient* dummyChromeClient = adoptPtr(new EmptyChromeClient).leakPtr();

+ static ChromeClient* dummyChromeClient = EmptyChromeClient::create().leakPtr();

haraken 2015/08/13 10:52:06 Not related to this CL, it would be better to use

Yuta Kitamura 2015/08/14 04:40:38 Done.

pageClients.chromeClient = dummyChromeClient;

static ContextMenuClient* dummyContextMenuClient = adoptPtr(new EmptyContextMenuClient).leakPtr();

« no previous file with comments | « Source/core/loader/EmptyClients.h ('k') | Source/core/svg/graphics/SVGImage.h » ('j') | no next file with comments »