Source/web/WebPagePopupImpl.h - Issue 1291903003: Oilpan: Move ChromeClient classes into Oilpan heap.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/WebPagePopupImpl.h

Issue 1291903003: Oilpan: Move ChromeClient classes into Oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Make Page::PageClients STACK_ALLOCATED(). Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« Source/web/InspectorOverlayImpl.cpp ('K') | « Source/web/InspectorOverlayImpl.cpp ('k') | Source/web/WebPagePopupImpl.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 90 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
101 explicit WebPagePopupImpl(WebWidgetClient*);	101 explicit WebPagePopupImpl(WebWidgetClient*);

102 bool initializePage();	102 bool initializePage();

103 void destroyPage();	103 void destroyPage();

104 void setRootGraphicsLayer(GraphicsLayer*);	104 void setRootGraphicsLayer(GraphicsLayer*);

105 void setIsAcceleratedCompositingActive(bool enter);	105 void setIsAcceleratedCompositingActive(bool enter);

106	106

107 WebWidgetClient* m_widgetClient;	107 WebWidgetClient* m_widgetClient;

108 WebRect m_windowRectInScreen;	108 WebRect m_windowRectInScreen;

109 WebViewImpl* m_webView;	109 WebViewImpl* m_webView;

110 OwnPtrWillBePersistent<Page> m_page;	110 OwnPtrWillBePersistent<Page> m_page;

111 OwnPtr<PagePopupChromeClient> m_chromeClient;	111 OwnPtrWillBePersistent<PagePopupChromeClient> m_chromeClient;

112 PagePopupClient* m_popupClient;	112 PagePopupClient* m_popupClient;

113 bool m_closing;	113 bool m_closing;

114	114

115 WebLayerTreeView* m_layerTreeView;	115 WebLayerTreeView* m_layerTreeView;

116 WebLayer* m_rootLayer;	116 WebLayer* m_rootLayer;

117 GraphicsLayer* m_rootGraphicsLayer;	117 GraphicsLayer* m_rootGraphicsLayer;

118 bool m_isAcceleratedCompositingActive;	118 bool m_isAcceleratedCompositingActive;

119	119

120 friend class WebPagePopup;	120 friend class WebPagePopup;

121 friend class PagePopupChromeClient;	121 friend class PagePopupChromeClient;

122 };	122 };

123	123

124 DEFINE_TYPE_CASTS(WebPagePopupImpl, WebWidget, widget, widget->isPagePopup(), wi dget.isPagePopup());	124 DEFINE_TYPE_CASTS(WebPagePopupImpl, WebWidget, widget, widget->isPagePopup(), wi dget.isPagePopup());

125 // WebPagePopupImpl is the only implementation of PagePopup, so no	125 // WebPagePopupImpl is the only implementation of PagePopup, so no

126 // further checking required.	126 // further checking required.

127 DEFINE_TYPE_CASTS(WebPagePopupImpl, PagePopup, popup, true, true);	127 DEFINE_TYPE_CASTS(WebPagePopupImpl, PagePopup, popup, true, true);

128	128

129 } // namespace blink	129 } // namespace blink

130 #endif // WebPagePopupImpl_h	130 #endif // WebPagePopupImpl_h

OLD	NEW