Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1637)

Side by Side Diff: Source/core/page/Page.h

Issue 1291903003: Oilpan: Move ChromeClient classes into Oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix a raw reference in InspectorOverlayImpl.cpp. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/loader/EmptyClients.cpp ('k') | Source/core/svg/graphics/SVGImage.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserv ed. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserv ed.
3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 float deviceScaleFactor(LocalFrame*); 69 float deviceScaleFactor(LocalFrame*);
70 70
71 class CORE_EXPORT Page final : public NoBaseWillBeGarbageCollectedFinalized<Page >, public WillBeHeapSupplementable<Page>, public PageLifecycleNotifier, public S ettingsDelegate { 71 class CORE_EXPORT Page final : public NoBaseWillBeGarbageCollectedFinalized<Page >, public WillBeHeapSupplementable<Page>, public PageLifecycleNotifier, public S ettingsDelegate {
72 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(Page); 72 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(Page);
73 WTF_MAKE_NONCOPYABLE(Page); 73 WTF_MAKE_NONCOPYABLE(Page);
74 friend class Settings; 74 friend class Settings;
75 public: 75 public:
76 static void platformColorsChanged(); 76 static void platformColorsChanged();
77 77
78 // It is up to the platform to ensure that non-null clients are provided whe re required. 78 // It is up to the platform to ensure that non-null clients are provided whe re required.
79 struct CORE_EXPORT PageClients { 79 struct CORE_EXPORT PageClients final {
80 WTF_MAKE_NONCOPYABLE(PageClients); WTF_MAKE_FAST_ALLOCATED(PageClients); 80 STACK_ALLOCATED();
81 WTF_MAKE_NONCOPYABLE(PageClients);
81 public: 82 public:
82 PageClients(); 83 PageClients();
83 ~PageClients(); 84 ~PageClients();
84 85
85 ChromeClient* chromeClient; 86 RawPtrWillBeMember<ChromeClient> chromeClient;
86 ContextMenuClient* contextMenuClient; 87 ContextMenuClient* contextMenuClient;
87 EditorClient* editorClient; 88 EditorClient* editorClient;
88 DragClient* dragClient; 89 DragClient* dragClient;
89 SpellCheckerClient* spellCheckerClient; 90 SpellCheckerClient* spellCheckerClient;
90 }; 91 };
91 92
92 explicit Page(PageClients&); 93 explicit Page(PageClients&);
93 ~Page() override; 94 ~Page() override;
94 95
95 void makeOrdinary(); 96 void makeOrdinary();
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 // A pointer to all the interfaces provided to in-process Frames for this Pa ge. 268 // A pointer to all the interfaces provided to in-process Frames for this Pa ge.
268 // FIXME: Most of the members of Page should move onto FrameHost. 269 // FIXME: Most of the members of Page should move onto FrameHost.
269 OwnPtrWillBeMember<FrameHost> m_frameHost; 270 OwnPtrWillBeMember<FrameHost> m_frameHost;
270 }; 271 };
271 272
272 extern template class CORE_EXTERN_TEMPLATE_EXPORT WillBeHeapSupplement<Page>; 273 extern template class CORE_EXTERN_TEMPLATE_EXPORT WillBeHeapSupplement<Page>;
273 274
274 } // namespace blink 275 } // namespace blink
275 276
276 #endif // Page_h 277 #endif // Page_h
OLDNEW
« no previous file with comments | « Source/core/loader/EmptyClients.cpp ('k') | Source/core/svg/graphics/SVGImage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698