third_party/protobuf/python/mox.py - Issue 1291903002: Pull new version of protobuf sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/python/mox.py

Issue 1291903002: Pull new version of protobuf sources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Build fix attempts Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/protobuf/python/mox.py

diff --git a/third_party/protobuf/python/mox.py b/third_party/protobuf/python/mox.py

index ce80ba505c93698ae91766ea9ec8d83876479d6f..257468e52d72854667e6c848060e1f68e6a7b25e 100755

--- a/third_party/protobuf/python/mox.py

+++ b/third_party/protobuf/python/mox.py

@@ -31,7 +31,7 @@ If an unexpected method (or an expected method with unexpected

parameters) is called, then an exception will be raised.

Once you are done interacting with the mock, you need to verify that

-all the expected interactions occured. (Maybe your code exited

+all the expected interactions occurred. (Maybe your code exited

prematurely without calling some cleanup method!) The verify phase

ensures that every expected method was called; otherwise, an exception

will be raised.