Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 12919014: Do not use SkTDS32Array when building for 64 bit. (Closed)

Created:
7 years, 9 months ago by scroggo
Modified:
7 years, 9 months ago
Reviewers:
caryclark
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Do not use SkTDS32Array when building for 64 bit. This class is used for pointers, which won't work on 64 bit. Fixes SampleApp on Mac debug 64 bit. BUG=https://code.google.com/p/skia/issues/detail?id=1169 Committed: https://code.google.com/p/skia/source/detail?r=8203

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/animator/SkTDArray_Experimental.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
Cary, was this your file originally (I'm guessing since it's in animator)?
7 years, 9 months ago (2013-03-18 19:46:09 UTC) #1
caryclark
lgtm I expect that I did write it, but I don't recall the motivation. I'm ...
7 years, 9 months ago (2013-03-18 19:53:25 UTC) #2
scroggo
7 years, 9 months ago (2013-03-18 19:56:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r8203 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698