Issue 12919013: move SK_MMAP_SUPPORT into SkPreConfig, so we can know about its availability

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12919013: move SK_MMAP_SUPPORT into SkPreConfig, so we can know about its availability (Closed)

Created:
7 years, 9 months ago by reed1

Modified:
7 years, 9 months ago

Reviewers:
bungeman-skia

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/

Visibility:
Public.

More Reviews

Description

move SK_MMAP_SUPPORT into SkPreConfig, so we can know about its availability throughout the code. Add SkData::NewFromMMap() help factory. Refactor (now gone) SkMMapStream into SkStream::NewFromFile() factory Committed: https://code.google.com/p/skia/source/detail?r=8200

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+156 lines, -223 lines)			Patch
M	trunk/gyp/core.gyp	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/gyp/core.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/include/core/SkData.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
D	trunk/include/core/SkMMapStream.h	View	1 chunk	+0 lines, -30 lines	0 comments	Download
M	trunk/include/core/SkPreConfig.h	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	trunk/include/core/SkStream.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	trunk/src/core/SkData.cpp	View	3 chunks	+22 lines, -0 lines	0 comments	Download
D	trunk/src/core/SkMMapStream.cpp	View	1 chunk	+0 lines, -77 lines	0 comments	Download
M	trunk/src/core/SkStream.cpp	View	2 chunks	+64 lines, -0 lines	0 comments	Download
M	trunk/src/ports/SkFontHost_android.cpp	View	4 chunks	+15 lines, -36 lines	0 comments	Download
M	trunk/src/ports/SkFontHost_ascender.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/ports/SkFontHost_freetype_mac.cpp	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	trunk/src/ports/SkFontHost_linux.cpp	View	5 chunks	+13 lines, -36 lines	0 comments	Download
M	trunk/src/ports/SkFontHost_simple.cpp	View	4 chunks	+13 lines, -35 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

reed1

7 years, 9 months ago (2013-03-18 19:08:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r8200 (presubmit successful).

Expand Messages | Collapse Messages