Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1291883002: Use precaching for more data: urls than just images. (Closed)

Created:
5 years, 4 months ago by Nate Chapin
Modified:
5 years, 4 months ago
Reviewers:
Mike West
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, kinuko, tyoshino+watch_chromium.org, Yoav Weiss
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use precaching for more data: urls than just images. Also, merge the data url path with the SubstitueData path, as they do very similar work in emulating a cache hit. BUG=521112 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200738

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1

Patch Set 6 : Tweak determineRevalidationPolicy ordering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -89 lines) Patch
M LayoutTests/fast/css/link-alternate-style-recalc.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/FetchContext.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/ImageResource.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/fetch/ImageResource.cpp View 2 chunks +0 lines, -31 lines 0 comments Download
M Source/core/fetch/RawResource.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/RawResource.cpp View 1 2 chunks +1 line, -25 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.h View 1 2 3 4 5 5 chunks +5 lines, -4 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 2 3 4 5 7 chunks +62 lines, -18 lines 0 comments Download
M Source/core/loader/FrameFetchContext.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Nate Chapin
https://codereview.chromium.org/1291883002/diff/80001/Source/core/fetch/ResourceFetcher.cpp File Source/core/fetch/ResourceFetcher.cpp (right): https://codereview.chromium.org/1291883002/diff/80001/Source/core/fetch/ResourceFetcher.cpp#newcode568 Source/core/fetch/ResourceFetcher.cpp:568: if (isStaticData) This needs to come after downloadToFile(), since ...
5 years, 4 months ago (2015-08-14 20:48:46 UTC) #2
Mike West
LGTM, let's try it out.
5 years, 4 months ago (2015-08-17 15:29:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291883002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291883002/80001
5 years, 4 months ago (2015-08-17 17:25:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/40447)
5 years, 4 months ago (2015-08-17 18:20:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291883002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291883002/80001
5 years, 4 months ago (2015-08-17 21:50:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/100015)
5 years, 4 months ago (2015-08-17 22:45:09 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291883002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291883002/100001
5 years, 4 months ago (2015-08-17 23:54:00 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99427)
5 years, 4 months ago (2015-08-18 02:44:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291883002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291883002/100001
5 years, 4 months ago (2015-08-18 17:12:51 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 18:26:55 UTC) #19
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200738

Powered by Google App Engine
This is Rietveld 408576698