Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: service/memcache/memcache.go

Issue 1291813003: Make LazyMultiError constructed via function (Closed) Base URL: https://github.com/luci/gae.git@master
Patch Set: interface not pointer Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « service/datastore/multiarg.go ('k') | service/taskqueue/taskqueue.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: service/memcache/memcache.go
diff --git a/service/memcache/memcache.go b/service/memcache/memcache.go
index e2ba498d7d6cdb4cba339ecae697c7df42e32f28..a814f705b0c79c68b57afaefc331d0970ffba419 100644
--- a/service/memcache/memcache.go
+++ b/service/memcache/memcache.go
@@ -33,7 +33,7 @@ func (m *memcacheImpl) CompareAndSwap(item Item) error {
return errors.SingleError(m.CompareAndSwapMulti([]Item{item}))
}
-func filterItems(lme *errors.LazyMultiError, items []Item, nilErr error) ([]Item, []int) {
+func filterItems(lme errors.LazyMultiError, items []Item, nilErr error) ([]Item, []int) {
idxMap := make([]int, 0, len(items))
retItems := make([]Item, 0, len(items))
for i, itm := range items {
@@ -48,8 +48,8 @@ func filterItems(lme *errors.LazyMultiError, items []Item, nilErr error) ([]Item
}
func multiCall(items []Item, nilErr error, inner func(items []Item, cb RawCB) error) error {
- lme := errors.LazyMultiError{Size: len(items)}
- realItems, idxMap := filterItems(&lme, items, nilErr)
+ lme := errors.NewLazyMultiError(len(items))
+ realItems, idxMap := filterItems(lme, items, nilErr)
j := 0
err := inner(realItems, func(err error) {
lme.Assign(idxMap[j], err)
@@ -74,7 +74,7 @@ func (m *memcacheImpl) CompareAndSwapMulti(items []Item) error {
}
func (m *memcacheImpl) DeleteMulti(keys []string) error {
- lme := errors.LazyMultiError{Size: len(keys)}
+ lme := errors.NewLazyMultiError(len(keys))
i := 0
err := m.RawInterface.DeleteMulti(keys, func(err error) {
lme.Assign(i, err)
@@ -87,8 +87,8 @@ func (m *memcacheImpl) DeleteMulti(keys []string) error {
}
func (m *memcacheImpl) GetMulti(items []Item) error {
- lme := errors.LazyMultiError{Size: len(items)}
- realItems, idxMap := filterItems(&lme, items, ErrCacheMiss)
+ lme := errors.NewLazyMultiError(len(items))
+ realItems, idxMap := filterItems(lme, items, ErrCacheMiss)
if len(realItems) == 0 {
return lme.Get()
}
« no previous file with comments | « service/datastore/multiarg.go ('k') | service/taskqueue/taskqueue.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698