service/datastore/multiarg.go - Issue 1291813003: Make LazyMultiError constructed via function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/datastore/multiarg.go

Issue 1291813003: Make LazyMultiError constructed via function (Closed) Base URL: https://github.com/luci/gae.git@master

Patch Set: interface not pointer Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: service/datastore/multiarg.go

diff --git a/service/datastore/multiarg.go b/service/datastore/multiarg.go

index ea7325ffcafd831cb6eb3721bf99f5f3bc37b78d..3efa1493df86692ed1947c2985ba17e753f54b46 100644

--- a/service/datastore/multiarg.go

+++ b/service/datastore/multiarg.go

@@ -24,7 +24,7 @@ type multiArgType struct {

func (mat *multiArgType) GetKeysPMs(nk newKeyFunc, slice reflect.Value) ([]Key, []PropertyMap, error) {

retKey := make([]Key, slice.Len())

retPM := make([]PropertyMap, slice.Len())

- lme := errors.LazyMultiError{Size: len(retKey)}

+ lme := errors.NewLazyMultiError(len(retKey))

for i := range retKey {

key, err := mat.getKey(nk, slice.Index(i))

if !lme.Assign(i, err) {

« no previous file with comments | « service/datastore/datastore.go ('k') | service/memcache/memcache.go » ('j') | no next file with comments »