build/config/linux/pkg-config.py - Issue 1291803008: pkg-config.py should use --libs instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/linux/pkg-config.py

Issue 1291803008: pkg-config.py should use --libs instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/linux/pkg-config.py

diff --git a/build/config/linux/pkg-config.py b/build/config/linux/pkg-config.py

index fadcc0bbcf9dfbabd92e24475ecd2d7ed91b3ebd..3ebc13d145199f5509c2758433c0668e3b27c971 100644

--- a/build/config/linux/pkg-config.py

+++ b/build/config/linux/pkg-config.py

@@ -153,7 +153,7 @@ if options.libdir:

try:

flag_string = subprocess.check_output(

- [ options.pkg_config, "--cflags", "--libs-only-l", "--libs-only-L" ] +

+ [ options.pkg_config, "--cflags", "--libs" ] +

args, env=os.environ)

# For now just split on spaces to get the args out. This will break if

# pkgconfig returns quoted things with spaces in them, but that doesn't seem

« no previous file with comments | « no previous file | no next file » | no next file with comments »