Simplify parameters passed to path renderers

Simplify parameters passed to path renderers

It appears that CanDrawPathArgs::fTarget was only ever used to access the shaderCaps and no instances of onGetStencilSupport ever used the drawTarget and pipelineBuilder parameters.

Committed: https://skia.googlesource.com/skia/+/e7d4b2f5dc3c35f351ba120018c214f739447fb2

[robertphillips, 2015-08-12 22:42:10]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2015-08-13 13:49:36]

otherwise lgtm

https://codereview.chromium.org/1291803006/diff/2/src/gpu/GrPathRenderer.h
File src/gpu/GrPathRenderer.h (right):

https://codereview.chromium.org/1291803006/diff/2/src/gpu/GrPathRenderer.h#ne...
src/gpu/GrPathRenderer.h:98: SkAutoTUnref<const GrShaderCaps> fShaderCaps;
I don't think we need the ref/unref for this. We aren't doing it for the other
params. The caller is by definition holding on to the object (and not
transferring ownership to the called function).

[robertphillips, 2015-08-13 14:38:15]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-13 14:38:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1291803006/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1291803006/50001

[commit-bot: I haz the power, 2015-08-13 14:45:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-13 14:45:31]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-08-13 14:56:40]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2015-08-13 14:56:41]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1291803006/#ps50001
(title: "Add more validate methods")

[commit-bot: I haz the power, 2015-08-13 14:56:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1291803006/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1291803006/50001

[robertphillips, 2015-08-13 14:57:00]

https://codereview.chromium.org/1291803006/diff/2/src/gpu/GrPathRenderer.h
File src/gpu/GrPathRenderer.h (right):

https://codereview.chromium.org/1291803006/diff/2/src/gpu/GrPathRenderer.h#ne...
src/gpu/GrPathRenderer.h:98: SkAutoTUnref<const GrShaderCaps> fShaderCaps;
On 2015/08/13 13:49:35, bsalomon wrote:
> I don't think we need the ref/unref for this. We aren't doing it for the other
> params. The caller is by definition holding on to the object (and not
> transferring ownership to the called function).

Done.

[commit-bot: I haz the power, 2015-08-13 14:57:13]

Committed patchset #4 (id:50001) as
https://skia.googlesource.com/skia/+/e7d4b2f5dc3c35f351ba120018c214f739447fb2