Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1291803004: More MB fixes in preparation for flipping Linux bots to use MB. (Closed)

Created:
5 years, 4 months ago by Dirk Pranke
Modified:
5 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More MB fixes in preparation for flipping Linux bots to use MB. Two more changes. One, importantly, changes the GYP_DEFINE to enable goma from 'goma=1' to 'use_goma=1'. The other fixes the linux_full_bisect_builder to mirror the waterfall bot config and not the tryserver config, and so DCHECKs will not be enabled. R=brettw@chromium.org BUG=481692 Committed: https://crrev.com/0f43d2c299172e6fd24230edafe1b7c90f6c8f1a Cr-Commit-Position: refs/heads/master@{#343101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/mb/mb_config.pyl View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
Dirk Pranke
5 years, 4 months ago (2015-08-12 20:00:50 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291803004/1
5 years, 4 months ago (2015-08-12 20:01:13 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-12 21:20:46 UTC) #5
brettw
lgtm
5 years, 4 months ago (2015-08-12 21:27:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291803004/1
5 years, 4 months ago (2015-08-12 21:36:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-12 21:41:06 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 21:41:52 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f43d2c299172e6fd24230edafe1b7c90f6c8f1a
Cr-Commit-Position: refs/heads/master@{#343101}

Powered by Google App Engine
This is Rietveld 408576698