Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 12918029: New filter targeted at desk_googlespreadsheet overdraw issues (Closed)

Created:
7 years, 9 months ago by robertphillips
Modified:
7 years, 9 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

This picture record optimization addresses some of the toolbar button overdraw issues in desk_googlespreadsheet. Here is when it fires: Executing desk_googlespreadsheet.skp 0: 9 Executing desk_googlespreadsheetdashed.skp 0: 9 Here is the performance impact (left is old; right is new) desk_googlespreadsheetdashed.skp tile_256x256_gpu c 75.61 71.05 +4.56 +6.0% desk_googlespreadsheet.skp tile_256x256_gpu c 12.72 10.51 +2.21 +17.4% desk_googlespreadsheetdashed.skp tile_256x256 c 22.82 19.75 +3.07 +13.5% desk_googlespreadsheet.skp tile_256x256 c 6.78 4.64 +2.14 +31.6%

Patch Set 1 #

Patch Set 2 : Added comments #

Patch Set 3 : Handle some corner cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -0 lines) Patch
M debugger/SkDrawCommand.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M tools/filtermain.cpp View 1 2 2 chunks +188 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
7 years, 9 months ago (2013-03-27 19:25:50 UTC) #1
djsollen
lgtm
7 years, 9 months ago (2013-03-28 00:43:00 UTC) #2
robertphillips
7 years, 9 months ago (2013-03-28 12:25:42 UTC) #3
Message was sent while issue was closed.
committed as r8424

Powered by Google App Engine
This is Rietveld 408576698