Adds support for CoreAudioUtil::IsChannelLayoutSupported()

media/audio/win/core_audio_util_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/audio/win/core_audio_util_win.h"
 
 #include <Audioclient.h>
 #include <Functiondiscoverykeys_devpkey.h>
 
 #include "base/command_line.h"
@@ skipping 49 matching lines @@
       return CHANNEL_LAYOUT_7_1_WIDE;
     case KSAUDIO_SPEAKER_7POINT1_SURROUND:
       DVLOG(2) << "KSAUDIO_SPEAKER_7POINT1_SURROUND=>CHANNEL_LAYOUT_7_1";
       return CHANNEL_LAYOUT_7_1;
     default:
       DVLOG(2) << "Unsupported channel layout: " << config;
       return CHANNEL_LAYOUT_UNSUPPORTED;
   }
 }
 
+// TODO(henrika): add mapping for all types in the ChannelLayout enumerator.
+static ChannelConfig ChannelLayoutToChannelConfig(ChannelLayout layout) {
+  switch (layout) {
+    case CHANNEL_LAYOUT_NONE:

[DaleCurtis, 2013/03/27 17:30:18]

These top two should be UNSUPPORTED.

[henrika (OOO until Aug 14), 2013/03/28 09:15:05]

Defined KSAUDIO_SPEAKER_UNSUPPORTED locally.

+      DVLOG(2) << "CHANNEL_LAYOUT_NONE=>KSAUDIO_SPEAKER_DIRECTOUT";
+      return KSAUDIO_SPEAKER_DIRECTOUT;
+    case CHANNEL_LAYOUT_UNSUPPORTED:
+      DVLOG(2) << "CHANNEL_LAYOUT_UNSUPPORTED=>KSAUDIO_SPEAKER_DIRECTOUT";
+      return KSAUDIO_SPEAKER_DIRECTOUT;
+    case CHANNEL_LAYOUT_MONO:
+      DVLOG(2) << "CHANNEL_LAYOUT_MONO=>KSAUDIO_SPEAKER_MONO";
+      return KSAUDIO_SPEAKER_MONO;
+    case CHANNEL_LAYOUT_STEREO:
+      DVLOG(2) << "CHANNEL_LAYOUT_STEREO=>KSAUDIO_SPEAKER_STEREO";
+      return KSAUDIO_SPEAKER_STEREO;
+    case CHANNEL_LAYOUT_QUAD:
+      DVLOG(2) << "CHANNEL_LAYOUT_QUAD=>KSAUDIO_SPEAKER_QUAD";
+      return KSAUDIO_SPEAKER_QUAD;
+    case CHANNEL_LAYOUT_4_0:
+      DVLOG(2) << "CHANNEL_LAYOUT_4_0=>KSAUDIO_SPEAKER_SURROUND";
+      return KSAUDIO_SPEAKER_SURROUND;
+    case CHANNEL_LAYOUT_5_1_BACK:
+      DVLOG(2) << "CHANNEL_LAYOUT_5_1_BACK=>KSAUDIO_SPEAKER_5POINT1";
+      return KSAUDIO_SPEAKER_5POINT1;
+    case CHANNEL_LAYOUT_5_1:
+      DVLOG(2) << "CHANNEL_LAYOUT_5_1=>KSAUDIO_SPEAKER_5POINT1_SURROUND";
+      return KSAUDIO_SPEAKER_5POINT1_SURROUND;
+    case CHANNEL_LAYOUT_7_1_WIDE:
+      DVLOG(2) << "CHANNEL_LAYOUT_7_1_WIDE=>KSAUDIO_SPEAKER_7POINT1";
+      return KSAUDIO_SPEAKER_7POINT1;
+    case CHANNEL_LAYOUT_7_1:
+      DVLOG(2) << "CHANNEL_LAYOUT_7_1=>KSAUDIO_SPEAKER_7POINT1_SURROUND";
+      return KSAUDIO_SPEAKER_7POINT1_SURROUND;
+    default:
+      DVLOG(2) << "Unsupported channel layout: " << layout;
+      return CHANNEL_LAYOUT_UNSUPPORTED;

[DaleCurtis, 2013/03/27 17:30:18]

I'm surprised this ChannelLayout returns correctly as a ChannelConfig?

[henrika (OOO until Aug 14), 2013/03/28 09:15:05]

fixed.

+  }
+}
+
+static std::ostream& operator<<(std::ostream& os,
+                                const WAVEFORMATPCMEX& format) {
+  os << "wFormatTag: 0x" << std::hex << format.Format.wFormatTag
+     << ", nChannels: " << std::dec << format.Format.nChannels
+     << ", nSamplesPerSec: " << format.Format.nSamplesPerSec
+     << ", nAvgBytesPerSec: " << format.Format.nAvgBytesPerSec
+     << ", nBlockAlign: " << format.Format.nBlockAlign
+     << ", wBitsPerSample: " << format.Format.wBitsPerSample
+     << ", cbSize: " << format.Format.cbSize
+     << ", wValidBitsPerSample: " << format.Samples.wValidBitsPerSample
+     << ", dwChannelMask: 0x" << std::hex << format.dwChannelMask;
+  return os;
+}
+
 bool LoadAudiosesDll() {
   static const wchar_t* const kAudiosesDLL =
       L"%WINDIR%\\system32\\audioses.dll";
 
   wchar_t path[MAX_PATH] = {0};
   ExpandEnvironmentStringsW(kAudiosesDLL, path, arraysize(path));
   return (LoadLibraryExW(path, NULL, LOAD_WITH_ALTERED_SEARCH_PATH) != NULL);
 }
 
 bool CanCreateDeviceEnumerator() {
@@ skipping 262 matching lines @@
   ScopedCoMem<WAVEFORMATPCMEX> format_pcmex;
   HRESULT hr = client->GetMixFormat(
       reinterpret_cast<WAVEFORMATEX**>(&format_pcmex));
   if (FAILED(hr))
     return hr;
 
   size_t bytes = sizeof(WAVEFORMATEX) + format_pcmex->Format.cbSize;
   DCHECK_EQ(bytes, sizeof(WAVEFORMATPCMEX));
 
   memcpy(format, format_pcmex, bytes);
-
-  DVLOG(2) << "wFormatTag: 0x" << std::hex << format->Format.wFormatTag
-           << ", nChannels: " << std::dec << format->Format.nChannels
-           << ", nSamplesPerSec: " << format->Format.nSamplesPerSec
-           << ", nAvgBytesPerSec: " << format->Format.nAvgBytesPerSec
-           << ", nBlockAlign: " << format->Format.nBlockAlign
-           << ", wBitsPerSample: " << format->Format.wBitsPerSample
-           << ", cbSize: " << format->Format.cbSize
-           << ", wValidBitsPerSample: " << format->Samples.wValidBitsPerSample
-           << ", dwChannelMask: 0x" << std::hex << format->dwChannelMask;
+  DVLOG(2) << *format;
 
   return hr;
 }
 
 HRESULT CoreAudioUtil::GetDefaultSharedModeMixFormat(
     EDataFlow data_flow, ERole role, WAVEFORMATPCMEX* format) {
   DCHECK(IsSupported());
   ScopedComPtr<IAudioClient> client(CreateDefaultClient(data_flow, role));
   if (!client) {
     // Map NULL-pointer to new error code which can be different from the
@@ skipping 11 matching lines @@
   HRESULT hr = client->IsFormatSupported(
       share_mode, reinterpret_cast<const WAVEFORMATEX*>(format),
       reinterpret_cast<WAVEFORMATEX**>(&closest_match));
 
   // This log can only be triggered for shared mode.
   DLOG_IF(ERROR, hr == S_FALSE) << "Format is not supported "
                                 << "but a closest match exists.";
   // This log can be triggered both for shared and exclusive modes.
   DLOG_IF(ERROR, hr == AUDCLNT_E_UNSUPPORTED_FORMAT) << "Unsupported format.";
   if (hr == S_FALSE) {
-    DVLOG(2) << "wFormatTag: " << closest_match->Format.wFormatTag
-             << ", nChannels: " << closest_match->Format.nChannels
-             << ", nSamplesPerSec: " << closest_match->Format.nSamplesPerSec
-             << ", wBitsPerSample: " << closest_match->Format.wBitsPerSample;
+    DVLOG(2) << *closest_match;
   }
 
   return (hr == S_OK);
 }
 
+bool CoreAudioUtil::IsChannelLayoutSupported(EDataFlow data_flow, ERole role,
+                                             ChannelLayout channel_layout) {
+  DCHECK(IsSupported());
+
+  // First, get the preferred mixing format for shared mode streams.
+
+  ScopedComPtr<IAudioClient> client(CreateDefaultClient(data_flow, role));
+  if (!client)
+    return false;
+
+  WAVEFORMATPCMEX format;
+  HRESULT hr = CoreAudioUtil::GetSharedModeMixFormat(client, &format);
+  if (FAILED(hr))
+    return false;
+
+  // Next, check if it is possible to use an alternative format where the
+  // channel layout (and possibly number of channels) is modified.
+
+  const int channels = ChannelLayoutToChannelCount(channel_layout);
+  if (channels != format.Format.nChannels) {
+    format.Format.nChannels = channels;
+    format.Format.nBlockAlign = (format.Format.wBitsPerSample / 8) * channels;
+    format.Format.nAvgBytesPerSec = format.Format.nSamplesPerSec *
+                                    format.Format.nBlockAlign;
+  }
+
+  ChannelConfig new_config = ChannelLayoutToChannelConfig(channel_layout);
+  format.dwChannelMask = new_config;

[DaleCurtis, 2013/03/27 17:30:18]

Bail early if new_config == unsupported? Should probably be the first thing
checked before any allocations.

[henrika (OOO until Aug 14), 2013/03/28 09:15:05]

Done.

+  DVLOG(2) << format;
+
+  // Some devices can initialize a shared-mode stream with a format that is
+  // not identical to the mix format obtained from the GetMixFormat() method.
+  // However, chances of succeeding increases if we use the same number of
+  // channels and the same sample rate as the mix format. I.e, this call will
+  // return true only in those cases where the audio engine is able to support
+  // an even wider range of shared-mode formats where the installation package
+  // for the audio device includes a local effects (LFX) audio processing
+  // object (APO) that can handle format conversions.
+  return CoreAudioUtil::IsFormatSupported(client, AUDCLNT_SHAREMODE_SHARED,

[DaleCurtis, 2013/03/27 17:30:18]

align &format or wrap the whole line.

[henrika (OOO until Aug 14), 2013/03/28 09:15:05]

Done.

+      &format);
+}
+
 HRESULT CoreAudioUtil::GetDevicePeriod(IAudioClient* client,
                                        AUDCLNT_SHAREMODE share_mode,
                                        REFERENCE_TIME* device_period) {
   DCHECK(IsSupported());
 
   // Get the period of the engine thread.
   REFERENCE_TIME default_period = 0;
   REFERENCE_TIME minimum_period = 0;
   HRESULT hr = client->GetDevicePeriod(&default_period, &minimum_period);
   if (FAILED(hr))
@@ skipping 186 matching lines @@
     return false;
 
   // Using the AUDCLNT_BUFFERFLAGS_SILENT flag eliminates the need to
   // explicitly write silence data to the rendering buffer.
   DVLOG(2) << "filling up " << num_frames_to_fill << " frames with silence";
   return SUCCEEDED(render_client->ReleaseBuffer(num_frames_to_fill,
                                                 AUDCLNT_BUFFERFLAGS_SILENT));
 }
 
 }  // namespace media