Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1901)

Unified Diff: chrome/browser/extensions/activity_log.h

Issue 12918020: Removing arguments from the activity log (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing include Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/activity_log.cc » ('j') | chrome/browser/extensions/activity_log.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/activity_log.h
diff --git a/chrome/browser/extensions/activity_log.h b/chrome/browser/extensions/activity_log.h
index 2c01cd5495b3b29ff9a5e82ee0b33315f431d666..5fb64bc751892bf42fe978b49ea8cb18575e1a3b 100644
--- a/chrome/browser/extensions/activity_log.h
+++ b/chrome/browser/extensions/activity_log.h
@@ -12,6 +12,7 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/callback.h"
+#include "base/hash_tables.h"
#include "base/memory/singleton.h"
#include "base/observer_list_threadsafe.h"
#include "base/synchronization/lock.h"
@@ -199,6 +200,13 @@ class ActivityLog : public ProfileKeyedService,
bool log_activity_to_stdout_;
bool log_activity_to_ui_;
+ // log_arguments controls whether to log API call arguments. By default, we
+ // don't log most arguments to avoid saving too much data. In testing mode,
+ // argument collection is enabled. We also whitelist some arguments for
+ // collection regardless of whether this bool is true.
+ bool log_arguments_;
+ base::hash_set<std::string> arg_whitelist_api_;
+
DISALLOW_COPY_AND_ASSIGN(ActivityLog);
};
« no previous file with comments | « no previous file | chrome/browser/extensions/activity_log.cc » ('j') | chrome/browser/extensions/activity_log.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698