Removing arguments from the activity log

chrome/browser/extensions/activity_log.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_H_
 #define CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
+#include "base/hash_tables.h"
 #include "base/memory/singleton.h"
 #include "base/observer_list_threadsafe.h"
 #include "base/synchronization/lock.h"
 #include "base/threading/thread.h"
 #include "chrome/browser/extensions/activity_actions.h"
 #include "chrome/browser/extensions/activity_database.h"
 #include "chrome/browser/extensions/tab_helper.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_dependency_manager.h"
 #include "chrome/browser/profiles/profile_keyed_service.h"
@@ skipping 46 matching lines @@
                       Observer* observer);
 
   // Check for the existence observer list by extension_id.
   bool HasObservers(const Extension* extension) const;
 
   // Log a successful API call made by an extension.
   // This will create an APIAction for storage in the database.
   // (Note: implemented as a wrapper for LogAPIActionInternal.)
   void LogAPIAction(const Extension* extension,
                     const std::string& name,    // e.g., tabs.get
-                    const ListValue* args,      // the argument values e.g. 46
+                    ListValue* args,            // the argument values e.g. 46
                     const std::string& extra);  // any extra logging info
 
   // Log an event notification delivered to an extension.
   // This will create an APIAction for storage in the database.
   // (Note: implemented as a wrapper for LogAPIActionInternal.)
   void LogEventAction(const Extension* extension,
                       const std::string& name,    // e.g., tabs.onUpdate
-                      const ListValue* args,      // arguments to the callback
+                      ListValue* args,            // arguments to the callback
                       const std::string& extra);  // any extra logging info
 
   // Log a blocked API call made by an extension.
   // This will create a BlockedAction for storage in the database.
   void LogBlockedAction(const Extension* extension,
                         const std::string& blocked_call,  // e.g., tabs.get
-                        const ListValue* args,            // argument values
+                        ListValue* args,                  // argument values
                         const char* reason,               // why it's blocked
                         const std::string& extra);        // extra logging info
 
   // Log an interaction between an extension and a URL.
   // This will create a DOMAction for storage in the database.
   // The technical message might be the list of content scripts that have been
   // injected, or the DOM API call; it's what's shown under "More".
   void LogDOMAction(const Extension* extension,
                     const GURL& url,                      // target URL
                     const string16& url_title,            // title of the URL
@@ skipping 85 matching lines @@
   // A map of extensions to activity observers for that extension.
   ObserverMap observers_;
 
   // The database wrapper that does the actual database I/O.
   scoped_refptr<extensions::ActivityDatabase> db_;
 
   // Whether to log activity to stdout or the UI. These are set by switches.
   bool log_activity_to_stdout_;
   bool log_activity_to_ui_;
 
+  // log_arguments controls whether to log API call arguments. By default, we
+  // don't log most arguments to avoid saving too much data. In testing mode,
+  // argument collection is enabled. We also whitelist some arguments for
+  // collection regardless of whether this bool is true.
+  bool log_arguments_;
+  base::hash_set<std::string> arg_whitelist_api_;
+
   DISALLOW_COPY_AND_ASSIGN(ActivityLog);
 };
 
 // Each profile has different extensions, so we keep a different database for
 // each profile.
 class ActivityLogFactory : public ProfileKeyedServiceFactory {
  public:
   static ActivityLog* GetForProfile(Profile* profile) {
     return static_cast<ActivityLog*>(
         GetInstance()->GetServiceForProfile(profile, true));
@@ skipping 13 matching lines @@
 
   virtual bool ServiceRedirectedInIncognito() const OVERRIDE;
 
   DISALLOW_COPY_AND_ASSIGN(ActivityLogFactory);
 };
 
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_H_