Removing arguments from the activity log

chrome/browser/extensions/activity_log.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/activity_log.h"
 
 #include <set>
 #include <vector>
 #include "base/command_line.h"
 #include "base/json/json_string_value_serializer.h"
@@ skipping 130 matching lines @@
 // ActivityLog
 
 // Use GetInstance instead of directly creating an ActivityLog.
 ActivityLog::ActivityLog(Profile* profile) {
   // enable-extension-activity-logging and enable-extension-activity-ui
   log_activity_to_stdout_ = CommandLine::ForCurrentProcess()->
       HasSwitch(switches::kEnableExtensionActivityLogging);
   log_activity_to_ui_ = CommandLine::ForCurrentProcess()->
       HasSwitch(switches::kEnableExtensionActivityUI);
 
+  // enable-extension-activity-log-testing
+  // Currently, this just controls whether arguments are collected. In the
+  // future, it may also control other optional activity log features.
+  log_arguments_ = CommandLine::ForCurrentProcess()->
+      HasSwitch(switches::kEnableExtensionActivityLogTesting);
+  if (!log_arguments_) {
+    for (int i = 0; i < APIAction::kSizeAlwaysLog; i++) {
+      arg_whitelist_api_.insert(std::string(APIAction::kAlwaysLog[i]));
+    }
+  }
+
   // If the database cannot be initialized for some reason, we keep
   // chugging along but nothing will get recorded. If the UI is
   // available, things will still get sent to the UI even if nothing
   // is being written to the database.
   db_ = new ActivityDatabase();
   if (!IsLogEnabled()) return;
   base::FilePath base_dir = profile->GetPath();
   base::FilePath database_name = base_dir.Append(
       chrome::kExtensionActivityLogFilename);
   KillActivityDatabaseErrorDelegate* error_delegate =
@@ skipping 65 matching lines @@
     LOG(ERROR) << "Unknown API call! " << api_call;
   }
 }
 
 // A wrapper around LogAPIActionInternal, but we know it's an API call.
 void ActivityLog::LogAPIAction(const Extension* extension,
                                const std::string& api_call,
                                const ListValue* args,
                                const std::string& extra) {
   if (!IsLogEnabled()) return;
-  LogAPIActionInternal(extension, api_call, args, extra, APIAction::CALL);
+  if (log_arguments_ ||

[Matt Perry, 2013/03/19 01:25:06]

nit: more compact:
 bool log_args = ...;
 LogAPIActionInternal(extension, api_call,
    log_args ? args : new ListValue(),
    extra, APIAction::CALL);

+      arg_whitelist_api_.find(api_call) != arg_whitelist_api_.end()) {
+    LogAPIActionInternal(extension,
+                         api_call,
+                         args,
+                         extra,
+                         APIAction::CALL);
+  } else {
+    LogAPIActionInternal(extension,
+                         api_call,
+                         new ListValue(),
+                         extra,
+                         APIAction::CALL);
+  }
 }
 
 // A wrapper around LogAPIActionInternal, but we know it's actually an event
 // being fired and triggering extension code. Having the two separate methods
 // (LogAPIAction vs LogEventAction) lets us hide how we actually choose to
 // handle them. Right now they're being handled almost the same.
 void ActivityLog::LogEventAction(const Extension* extension,
                                  const std::string& api_call,
                                  const ListValue* args,
                                  const std::string& extra) {
   if (!IsLogEnabled()) return;
-  LogAPIActionInternal(extension,
-                       api_call,
-                       args,
-                       extra,
-                       APIAction::EVENT_CALLBACK);
+  if (log_arguments_)
+    LogAPIActionInternal(extension,
+                         api_call,
+                         args,
+                         extra,
+                         APIAction::EVENT_CALLBACK);
+  else
+    LogAPIActionInternal(extension,
+                         api_call,
+                         new ListValue(),
+                         extra,
+                         APIAction::EVENT_CALLBACK);
 }
 
 void ActivityLog::LogBlockedAction(const Extension* extension,
                                    const std::string& blocked_call,
                                    const ListValue* args,
                                    const char* reason,
                                    const std::string& extra) {
   if (!IsLogEnabled()) return;
   scoped_refptr<BlockedAction> action = new BlockedAction(extension->id(),
                                                           base::Time::Now(),
@@ skipping 144 matching lines @@
       return "content_script";
     case ActivityLog::ACTIVITY_EVENT_DISPATCH:
       return "event_dispatch";
     default:
       NOTREACHED();
       return "";
   }
 }
 
 }  // namespace extensions