Issue 12918017: [android] remove obsolete findbugs suppressions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12918017: [android] remove obsolete findbugs suppressions (Closed)

Created:
7 years, 9 months ago by Paweł Hajdan Jr.

Modified:
7 years, 9 months ago

Reviewers:
eroman

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[android] remove obsolete findbugs suppressions According to trybots they were needed. Not sure what's going on. TBR=eroman BUG=70818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188830

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	build/android/findbugs_filter/findbugs_known_bugs.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Committed patchset #1 manually as r188830 (presubmit successful).

7 years, 9 months ago (2013-03-18 21:29:20 UTC) #1

eroman

Is the bug number on this issue accurate? I don't see the relationship.

7 years, 9 months ago (2013-03-18 21:38:40 UTC) #3

Message was sent while issue was closed.

Oh I see, you added those in r188822.
LGTM then

Expand Messages | Collapse Messages