Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Unified Diff: content/browser/renderer_host/render_sandbox_host_linux.cc

Issue 12918004: mmap the opened file descriptor in the renderer process, close the fd in the browser process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/font_config_ipc_linux.cc » ('j') | content/common/font_config_ipc_linux.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_sandbox_host_linux.cc
===================================================================
--- content/browser/renderer_host/render_sandbox_host_linux.cc (revision 188729)
+++ content/browser/renderer_host/render_sandbox_host_linux.cc (working copy)
@@ -223,7 +223,13 @@
reply.WriteBool(true);
}
+ // The receiver will have its own access to the file, so we will close it
+ // after this send.
SendRendererReply(fds, reply, result_fd);
+
+ if (result_fd >= 0) {
+ DCHECK(!HANDLE_EINTR(close(result_fd)));
piman 2013/03/18 19:49:14 I'm not the biggest fan of side-effects inside of
reed1 2013/03/18 20:15:41 Done.
+ }
}
void HandleGetFontFamilyForChars(int fd, const Pickle& pickle,
« no previous file with comments | « no previous file | content/common/font_config_ipc_linux.cc » ('j') | content/common/font_config_ipc_linux.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698