content/browser/renderer_host/render_sandbox_host_linux.cc - Issue 12918004: mmap the opened file descriptor in the renderer process, close the fd in the browser process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_sandbox_host_linux.cc

Issue 12918004: mmap the opened file descriptor in the renderer process, close the fd in the browser process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_sandbox_host_linux.cc

===================================================================

--- content/browser/renderer_host/render_sandbox_host_linux.cc (revision 188729)

+++ content/browser/renderer_host/render_sandbox_host_linux.cc (working copy)

@@ -223,7 +223,13 @@

reply.WriteBool(true);

}

+ // The receiver will have its own access to the file, so we will close it

+ // after this send.

SendRendererReply(fds, reply, result_fd);

+ if (result_fd >= 0) {

+ DCHECK(!HANDLE_EINTR(close(result_fd)));

jln (very slow on Chromium) 2013/03/19 10:23:27 We missed moving this out of DCHECK. And it's argu

+ }

}

void HandleGetFontFamilyForChars(int fd, const Pickle& pickle,

« no previous file with comments | « no previous file | content/common/font_config_ipc_linux.cc » ('j') | no next file with comments »