GN(android): Add scripts & runtime logic for installing _managed apks

build/config/android/rules.gni

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//base/android/linker/config.gni")
 import("//build/config/android/config.gni")
 import("//build/config/android/internal_rules.gni")
 import("//build/toolchain/toolchain.gni")
 import("//third_party/android_platform/config.gni")
 import("//tools/grit/grit_rule.gni")
@@ skipping 1364 matching lines @@
   if (defined(invoker.final_apk_path)) {
     _final_apk_path = invoker.final_apk_path
   } else if (defined(invoker.apk_name)) {
     _final_apk_path = "$root_build_dir/apks/" + invoker.apk_name + ".apk"
   }
   _dist_jar_path_list =
       process_file_template(
           [ _final_apk_path ],
           "$root_build_dir/test.lib.java/{{source_name_part}}.jar")
   _dist_jar_path = _dist_jar_path_list[0]
+  _final_apk_path_no_ext_list =

[jbudorick, 2015/08/23 02:01:28]

Are these only used in the managed_create_script action? If so, why not define
them there?

[agrieve, 2015/08/26 00:22:40]

It's used at line 1785 as well.

+      process_file_template([ _final_apk_path ],
+                            "{{source_dir}}/{{source_name_part}}")
+  _final_apk_path_no_ext = _final_apk_path_no_ext_list[0]
 
   _native_libs = []
 
   _version_code = "1"
   if (defined(invoker.version_code)) {
     _version_code = invoker.version_code
   }
 
   _version_name = "Developer Build"
   if (defined(invoker.version_name)) {
@@ skipping 82 matching lines @@
   if (defined(invoker.android_manifest_dep)) {
     _android_manifest_deps = [ invoker.android_manifest_dep ]
   }
   _android_manifest = invoker.android_manifest
 
   _rebased_build_config = rebase_path(_build_config, root_build_dir)
   _create_abi_split =
       defined(invoker.create_abi_split) && invoker.create_abi_split
   _create_density_splits =
       defined(invoker.create_density_splits) && invoker.create_density_splits
+  _create_language_splits =
+      defined(invoker.language_splits) && invoker.language_splits != []
 
   # Help GN understand that _create_abi_split is not unused (bug in GN).
   assert(_create_abi_split || true)
 
   build_config_target = "${_template_name}__build_config"
   write_build_config(build_config_target) {
     type = "android_apk"
     dex_path = final_dex_path
     resources_zip = resources_zip_path
     build_config = _build_config
@@ skipping 211 matching lines @@
 
   _final_deps += [ ":${_template_name}__create" ]
   _managed_final_deps += [ ":${_template_name}__create_managed" ]
   create_apk("${_template_name}__create") {
     apk_path = _final_apk_path
     android_manifest = _android_manifest
     resources_zip = _all_resources_zip_path
     dex_path = final_dex_path
     load_library_from_apk = _load_library_from_apk
     create_density_splits = _create_density_splits
-    if (defined(invoker.language_splits)) {
+    if (_create_language_splits) {
       language_splits = invoker.language_splits
     }
     if (defined(invoker.extensions_to_not_compress)) {
       extensions_to_not_compress = invoker.extensions_to_not_compress
     } else {
       # Allow icu data, v8 snapshots, and pak files to be loaded directly from
       # the .apk.
       # Note: These are actually suffix matches, not necessarily extensions.
       extensions_to_not_compress = ".dat,.bin,.pak"
     }
@@ skipping 36 matching lines @@
     generate_split_manifest(_manifest_rule) {
       main_manifest = _android_manifest
       out_manifest =
           "$gen_dir/split-manifests/${android_app_abi}/AndroidManifest.xml"
       split_name = "abi_${android_app_abi}"
       deps = _android_manifest_deps
     }
 
     _apk_rule = "${_template_name}__split_apk_abi_${android_app_abi}"
     _final_deps += [ ":$_apk_rule" ]
-    _managed_final_deps += [ ":${_apk_rule}_managed" ]
+
+    # Don't add this to _managed_final_deps since for managed installs we skip
+    # abi splits altogether.
     create_apk(_apk_rule) {
-      _split_paths = process_file_template(
-              [ _final_apk_path ],
-              "{{source_dir}}/{{source_name_part}}-abi-${android_app_abi}.apk")
-      apk_path = _split_paths[0]
+      apk_path = "${_final_apk_path_no_ext}-abi-${android_app_abi}.apk"
       base_path = "$gen_dir/$_apk_rule"
 
       manifest_outputs = get_target_outputs(":${_manifest_rule}")
       android_manifest = manifest_outputs[1]
       load_library_from_apk = _load_library_from_apk
 
       version_code = _version_code
       version_name = _version_name
 
       keystore_name = _keystore_name
       keystore_path = _keystore_path
       keystore_password = _keystore_password
 
       native_libs_dir = _native_libs_dir
       deps = [
         ":${_template_name}__prepare_native",
         ":${_manifest_rule}",
       ]
     }
   }
 
+  _managed_create_script_rule_name = "${_template_name}__managed_script"
+  _managed_final_deps += [ ":${_managed_create_script_rule_name}" ]
+  action(_managed_create_script_rule_name) {

[jbudorick, 2015/08/23 02:01:28]

nit: create_managed_script_rule_name?

[agrieve, 2015/08/26 00:22:40]

Done.

+    script = "//build/android/gyp/create_managed_install_script.py"
+    depfile = "$target_gen_dir/$target_name.d"
+
+    _generated_script_path =
+        "${root_out_dir}/bin/install_managed_${_template_name}"
+    outputs = [
+      depfile,
+      _generated_script_path,
+    ]
+
+    _rebased_apk_path_no_ext =
+        rebase_path(_final_apk_path_no_ext, root_build_dir)
+    _rebased_generated_script_path =
+        rebase_path(_generated_script_path, root_build_dir)
+    _rebased_depfile = rebase_path(depfile, root_build_dir)
+    args = [
+      "--apk-path=${_rebased_apk_path_no_ext}_managed.apk",
+      "--script-output-path=$_rebased_generated_script_path",
+      "--depfile=$_rebased_depfile",
+    ]
+    if (defined(_native_libs_dir)) {
+      _rebased_native_libs_dir = rebase_path(_native_libs_dir, root_build_dir)
+      args += [ "--lib-dir=$_rebased_native_libs_dir/$android_app_abi" ]
+    }
+    if (_create_density_splits) {
+      args += [ "--split=${_rebased_apk_path_no_ext}-density-*.apk" ]
+    }
+    if (_create_language_splits) {
+      args += [ "--split=${_rebased_apk_path_no_ext}-language-*.apk" ]
+    }
+  }
+
   group(target_name) {
     deps = _final_deps
     if (defined(invoker.data_deps)) {
       data_deps = invoker.data_deps
     }
   }
   group("${target_name}_managed") {
     deps = _managed_final_deps
     if (defined(invoker.data_deps)) {
       data_deps = invoker.data_deps
@@ skipping 421 matching lines @@
 template("uiautomator_test") {
   set_sources_assignment_filter([])
   if (defined(invoker.testonly)) {
     testonly = invoker.testonly
   }
   assert(target_name != "")
   assert(invoker.deps != [] || true)
   group(target_name) {
   }
 }