Remove command line flag to install an ephemeral app.

Remove command line flag to install an ephemeral app.

As ephemeral apps were never released and are being removed, this is no
longer needed.

BUG=517735
Committed: https://crrev.com/22ab8eef999925ec4d1671935954080df7eb6e7c
Cr-Commit-Position: refs/heads/master@{#344664}

[benwells, 2015-08-19 22:37:30]

benwells@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2015-08-19 22:40:27]

lgtm

https://codereview.chromium.org/1291793005/diff/20001/chrome/common/chrome_re...
File chrome/common/chrome_result_codes.h (right):

https://codereview.chromium.org/1291793005/diff/20001/chrome/common/chrome_re...
chrome/common/chrome_result_codes.h:82:
RESULT_CODE_INSTALL_FROM_WEBSTORE_ERROR_2,
Add NOTUSED to the name like the ones above/below? Update histograms.xml too.

[benwells, 2015-08-20 01:34:27]

benwells@chromium.org changed reviewers:
+ isherman@chromium.org

[benwells, 2015-08-20 01:34:28]

+isherman for histograms review

https://codereview.chromium.org/1291793005/diff/20001/chrome/common/chrome_re...
File chrome/common/chrome_result_codes.h (right):

https://codereview.chromium.org/1291793005/diff/20001/chrome/common/chrome_re...
chrome/common/chrome_result_codes.h:82:
RESULT_CODE_INSTALL_FROM_WEBSTORE_ERROR_2,
On 2015/08/19 22:40:27, Lei Zhang wrote:
> Add NOTUSED to the name like the ones above/below? Update histograms.xml too.

Done.

[Ilya Sherman, 2015-08-20 05:04:55]

LGTM

https://codereview.chromium.org/1291793005/diff/30001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1291793005/diff/30001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:72590: -  <int value="25"
label="chrome::RESULT_CODE_INSTALL_FROM_WEBSTORE_ERROR_2"/>
Hmm, it seems a little weird to rename the results, but ok.

[benwells, 2015-08-20 05:07:19]

On 2015/08/20 05:04:55, Ilya Sherman wrote:
> LGTM
> 
>
https://codereview.chromium.org/1291793005/diff/30001/tools/metrics/histogram...
> File tools/metrics/histograms/histograms.xml (left):
> 
>
https://codereview.chromium.org/1291793005/diff/30001/tools/metrics/histogram...
> tools/metrics/histograms/histograms.xml:72590: -  <int value="25"
> label="chrome::RESULT_CODE_INSTALL_FROM_WEBSTORE_ERROR_2"/>
> Hmm, it seems a little weird to rename the results, but ok.

Yeah, I wasn't sure whether to rename it or not. Do we generally rename result
codes, do you know?

[Ilya Sherman, 2015-08-20 05:10:26]

On 2015/08/20 05:07:19, benwells wrote:
> On 2015/08/20 05:04:55, Ilya Sherman wrote:
> > LGTM
> > 
> >
>
https://codereview.chromium.org/1291793005/diff/30001/tools/metrics/histogram...
> > File tools/metrics/histograms/histograms.xml (left):
> > 
> >
>
https://codereview.chromium.org/1291793005/diff/30001/tools/metrics/histogram...
> > tools/metrics/histograms/histograms.xml:72590: -  <int value="25"
> > label="chrome::RESULT_CODE_INSTALL_FROM_WEBSTORE_ERROR_2"/>
> > Hmm, it seems a little weird to rename the results, but ok.
> 
> Yeah, I wasn't sure whether to rename it or not. Do we generally rename result
> codes, do you know?

I think typically we just append "_OBSOLETE" or "_REMOVED" or something like
that to the old names so that historical data remains viewable.

[benwells, 2015-08-20 07:41:05]

On 2015/08/20 05:10:26, Ilya Sherman wrote:
> On 2015/08/20 05:07:19, benwells wrote:
> > On 2015/08/20 05:04:55, Ilya Sherman wrote:
> > > LGTM
> > > 
> > >
> >
>
https://codereview.chromium.org/1291793005/diff/30001/tools/metrics/histogram...
> > > File tools/metrics/histograms/histograms.xml (left):
> > > 
> > >
> >
>
https://codereview.chromium.org/1291793005/diff/30001/tools/metrics/histogram...
> > > tools/metrics/histograms/histograms.xml:72590: -  <int value="25"
> > > label="chrome::RESULT_CODE_INSTALL_FROM_WEBSTORE_ERROR_2"/>
> > > Hmm, it seems a little weird to rename the results, but ok.
> > 
> > Yeah, I wasn't sure whether to rename it or not. Do we generally rename
result
> > codes, do you know?
> 
> I think typically we just append "_OBSOLETE" or "_REMOVED" or something like
> that to the old names so that historical data remains viewable.

Looking at other codes, seems like we just leave them as they were. E.g. these
codes are all unused now, from what I can tell:
BAD_PROCESS_TYPE
IMPORTER_HUNG
EXIT_EXP1 (and 3 and 4)

I think the NOTUSED_* codes were introduced to debug something (see
crbug.com/152285), not as a pattern.

So unless anyone objects I will roll back to patch set 2 (lovingly titled
'Oops').

thestig - is that OK with you?

[Lei Zhang, 2015-08-20 09:33:25]

On 2015/08/20 07:41:05, benwells wrote:
> On 2015/08/20 05:10:26, Ilya Sherman wrote:
> > On 2015/08/20 05:07:19, benwells wrote:
> > > On 2015/08/20 05:04:55, Ilya Sherman wrote:
> > > > LGTM
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/1291793005/diff/30001/tools/metrics/histogram...
> > > > File tools/metrics/histograms/histograms.xml (left):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/1291793005/diff/30001/tools/metrics/histogram...
> > > > tools/metrics/histograms/histograms.xml:72590: -  <int value="25"
> > > > label="chrome::RESULT_CODE_INSTALL_FROM_WEBSTORE_ERROR_2"/>
> > > > Hmm, it seems a little weird to rename the results, but ok.
> > > 
> > > Yeah, I wasn't sure whether to rename it or not. Do we generally rename
> result
> > > codes, do you know?
> > 
> > I think typically we just append "_OBSOLETE" or "_REMOVED" or something like
> > that to the old names so that historical data remains viewable.
> 
> Looking at other codes, seems like we just leave them as they were. E.g. these
> codes are all unused now, from what I can tell:
> BAD_PROCESS_TYPE
> IMPORTER_HUNG
> EXIT_EXP1 (and 3 and 4)
> 
> I think the NOTUSED_* codes were introduced to debug something (see
> crbug.com/152285), not as a pattern.
> 
> So unless anyone objects I will roll back to patch set 2 (lovingly titled
> 'Oops').
> 
> thestig - is that OK with you?

Sure.

[benwells, 2015-08-21 01:22:22]

Patchset #3 (id:30001) has been deleted

[benwells, 2015-08-21 01:22:27]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2015-08-21 01:23:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1291793005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1291793005/20001

[commit-bot: I haz the power, 2015-08-21 02:55:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-21 02:56:01]

Patchset 2 (id:??) landed as
https://crrev.com/22ab8eef999925ec4d1671935954080df7eb6e7c
Cr-Commit-Position: refs/heads/master@{#344664}