chrome/installer/util/google_update_settings.cc - Issue 1291763002: Componentize kExperimentLabelSeparator & BuildExperimentDateString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/google_update_settings.cc

Issue 1291763002: Componentize kExperimentLabelSeparator & BuildExperimentDateString. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try moving kExperimentLabels into the component to fix the build on Windows Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/installer/util/google_update_experiment_util.cc ('k') | chrome/installer/util/google_update_settings_unittest.cc » ('j') | chrome/installer/util/google_update_settings_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/google_update_settings.cc

diff --git a/chrome/installer/util/google_update_settings.cc b/chrome/installer/util/google_update_settings.cc

index d99f6e5845d3162b427526db1910803d0efaf964..e493f5ad073ae6359de30d6dbeb4a5f7abc34b99 100644

--- a/chrome/installer/util/google_update_settings.cc

+++ b/chrome/installer/util/google_update_settings.cc

@@ -24,10 +24,10 @@

#include "chrome/installer/util/browser_distribution.h"

#include "chrome/installer/util/channel_info.h"

#include "chrome/installer/util/google_update_constants.h"

-#include "chrome/installer/util/google_update_experiment_util.h"

#include "chrome/installer/util/install_util.h"

#include "chrome/installer/util/installation_state.h"

#include "chrome/installer/util/product.h"

+#include "components/variations/variations_experiment_util.h"

Alexei Svitkine (slow) 2015/08/13 15:18:29 Do you need to update any usage of those declarati

sdefresne 2015/08/13 16:46:49 Done.

using base::win::RegKey;

using installer::InstallationState;