Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4828)

Unified Diff: chrome/installer/util/BUILD.gn

Issue 1291763002: Componentize kExperimentLabelSeparator & BuildExperimentDateString. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Try moving kExperimentLabels into the component to fix the build on Windows Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/BUILD.gn
diff --git a/chrome/installer/util/BUILD.gn b/chrome/installer/util/BUILD.gn
index ceedefd1ac017675d5e80c1d5fd2a9e3b90f3ef2..76819e55d673cd46f86e2cb3486ea5ffccbdd5f6 100644
--- a/chrome/installer/util/BUILD.gn
+++ b/chrome/installer/util/BUILD.gn
@@ -61,6 +61,7 @@ static_library("util") {
":strings",
"//base/third_party/dynamic_annotations",
"//components/metrics",
+ "//components/variations",
"//courgette:courgette_lib",
"//crypto",
"//third_party/bspatch",
@@ -122,8 +123,6 @@ static_library("util") {
"google_chrome_sxs_distribution.h",
"google_update_constants.cc",
"google_update_constants.h",
- "google_update_experiment_util.cc",
- "google_update_experiment_util.h",
"google_update_settings.cc",
"google_update_settings.h",
"google_update_util.cc",
@@ -167,13 +166,12 @@ static_library("util") {
]
} else {
sources = [
- "google_update_experiment_util.cc",
- "google_update_experiment_util.h",
"master_preferences.cc",
"master_preferences.h",
"master_preferences_constants.cc",
"master_preferences_constants.h",
]
+ deps += [ "//components/variations" ]
}
}
@@ -273,6 +271,7 @@ if (is_win) {
"//chrome:other_version",
"//chrome/common",
"//chrome/installer/test:alternate_version_generator_lib",
+ "//components/variations",
"//content/public/common",
# TODO(rockot): Remove this hack when we fix mojo environment deps.

Powered by Google App Engine
This is Rietveld 408576698