Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2524)

Unified Diff: chrome/chrome_installer_util.gypi

Issue 1291763002: Componentize kExperimentLabelSeparator & BuildExperimentDateString. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Try moving kExperimentLabels into the component to fix the build on Windows Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_installer_util.gypi
diff --git a/chrome/chrome_installer_util.gypi b/chrome/chrome_installer_util.gypi
index 334e427b1d170d0f1c8b0a3756caaf0b8c76c817..efce6963c4249ab4f78bf0d9ffb10638feef7a8e 100644
--- a/chrome/chrome_installer_util.gypi
+++ b/chrome/chrome_installer_util.gypi
@@ -10,6 +10,9 @@
'target_conditions': [
# This part is shared between the two versions of the target.
['installer_util_target==1', {
+ 'dependencies': [
+ '<(DEPTH)/components/components.gyp:variations',
+ ],
'sources': [
'installer/util/advanced_firewall_manager_win.cc',
'installer/util/advanced_firewall_manager_win.h',
@@ -56,8 +59,6 @@
'installer/util/google_chrome_sxs_distribution.h',
'installer/util/google_update_constants.cc',
'installer/util/google_update_constants.h',
- 'installer/util/google_update_experiment_util.cc',
- 'installer/util/google_update_experiment_util.h',
'installer/util/google_update_settings.cc',
'installer/util/google_update_settings.h',
'installer/util/google_update_util.cc',
@@ -212,11 +213,10 @@
'<(DEPTH)/base/base.gyp:base',
'<(DEPTH)/chrome/chrome_resources.gyp:chrome_resources',
'<(DEPTH)/chrome/chrome_resources.gyp:chrome_strings',
+ '<(DEPTH)/components/components.gyp:variations',
],
'sources': [
# Note: sources list duplicated in GN build.
- 'installer/util/google_update_experiment_util.cc',
- 'installer/util/google_update_experiment_util.h',
'installer/util/master_preferences.cc',
'installer/util/master_preferences.h',
'installer/util/master_preferences_constants.cc',

Powered by Google App Engine
This is Rietveld 408576698