Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9976)

Unified Diff: chrome/installer/gcapi/gcapi_omaha_experiment.cc

Issue 1291763002: Componentize kExperimentLabelSeparator & BuildExperimentDateString. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove "#if defined(OS_WIN)" from google_update_constants.cc Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/DEPS ('k') | chrome/installer/gcapi/gcapi_omaha_experiment_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/gcapi/gcapi_omaha_experiment.cc
diff --git a/chrome/installer/gcapi/gcapi_omaha_experiment.cc b/chrome/installer/gcapi/gcapi_omaha_experiment.cc
index 1724b971d4a4d9804368a4ac2b68836127f8078f..6e004344ca784059e4289510cc522f47a8e38ab0 100644
--- a/chrome/installer/gcapi/gcapi_omaha_experiment.cc
+++ b/chrome/installer/gcapi/gcapi_omaha_experiment.cc
@@ -12,8 +12,8 @@
#include "base/time/time.h"
#include "chrome/installer/gcapi/gcapi.h"
#include "chrome/installer/util/google_update_constants.h"
-#include "chrome/installer/util/google_update_experiment_util.h"
#include "chrome/installer/util/google_update_settings.h"
+#include "components/variations/variations_experiment_util.h"
namespace {
@@ -44,7 +44,7 @@ bool SetExperimentLabel(const wchar_t* brand_code,
// Split the original labels by the label separator.
std::vector<base::string16> entries = base::SplitString(
original_labels,
- base::string16(1, google_update::kExperimentLabelSeparator),
+ base::string16(1, variations::kExperimentLabelSeparator),
base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
// Keep all labels, but the one we want to add/replace.
@@ -56,7 +56,7 @@ bool SetExperimentLabel(const wchar_t* brand_code,
!base::StartsWith(entry, label_and_separator,
base::CompareCase::SENSITIVE)) {
new_labels += entry;
- new_labels += google_update::kExperimentLabelSeparator;
+ new_labels += variations::kExperimentLabelSeparator;
}
}
@@ -91,7 +91,7 @@ base::string16 GetGCAPIExperimentLabel(const wchar_t* brand_code,
label.c_str(),
brand_code,
GetCurrentRlzWeek(instance_time),
- installer::BuildExperimentDateString(
+ variations::BuildExperimentDateString(
instance_time).c_str());
return gcapi_experiment_label;
}
« no previous file with comments | « chrome/installer/DEPS ('k') | chrome/installer/gcapi/gcapi_omaha_experiment_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698