Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: chrome/installer/util/google_update_experiment_util.cc

Issue 1291763002: Componentize kExperimentLabelSeparator & BuildExperimentDateString. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove "#if defined(OS_WIN)" from google_update_constants.cc Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/google_update_experiment_util.cc
diff --git a/chrome/installer/util/google_update_experiment_util.cc b/chrome/installer/util/google_update_experiment_util.cc
deleted file mode 100644
index 2bff96f54847750f6f539a838539fe383dea9b7a..0000000000000000000000000000000000000000
--- a/chrome/installer/util/google_update_experiment_util.cc
+++ /dev/null
@@ -1,65 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/installer/util/google_update_experiment_util.h"
-
-#include <vector>
-
-#include "base/logging.h"
-#include "base/strings/stringprintf.h"
-#include "base/strings/utf_string_conversions.h"
-#include "base/time/time.h"
-
-namespace google_update {
-
-#if defined(OS_WIN)
-const wchar_t kExperimentLabels[] = L"experiment_labels";
-#endif
-
-const base::char16 kExperimentLabelSeparator = ';';
-
-} // namespace google_update
-
-namespace installer {
-
-namespace {
-
-const char* const kDays[] =
- { "Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat" };
-
-const char* const kMonths[] =
- { "Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug", "Sep",
- "Oct", "Nov", "Dec"};
-
-}
-
-base::string16 BuildExperimentDateString(const base::Time& current_time) {
- // The Google Update experiment_labels timestamp format is:
- // "DAY, DD0 MON YYYY HH0:MI0:SE0 TZ"
- // DAY = 3 character day of week,
- // DD0 = 2 digit day of month,
- // MON = 3 character month of year,
- // YYYY = 4 digit year,
- // HH0 = 2 digit hour,
- // MI0 = 2 digit minute,
- // SE0 = 2 digit second,
- // TZ = 3 character timezone
- base::Time::Exploded then = {};
- current_time.UTCExplode(&then);
- then.year += 1;
- DCHECK(then.HasValidValues());
-
- return base::UTF8ToUTF16(
- base::StringPrintf("%s, %02d %s %d %02d:%02d:%02d GMT",
- kDays[then.day_of_week],
- then.day_of_month,
- kMonths[then.month - 1],
- then.year,
- then.hour,
- then.minute,
- then.second));
-}
-
-} // namespace installer
-
« no previous file with comments | « chrome/installer/util/google_update_experiment_util.h ('k') | chrome/installer/util/google_update_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698