chrome/installer/util/BUILD.gn - Issue 1291763002: Componentize kExperimentLabelSeparator & BuildExperimentDateString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/BUILD.gn

Issue 1291763002: Componentize kExperimentLabelSeparator & BuildExperimentDateString. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move kExperimentLabels to chrome/installer/util/google_update_constants.h (fix Windows build) Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/installer/gcapi/gcapi_reactivation_test.cc ('k') | chrome/installer/util/google_update_constants.h » ('j') | chrome/installer/util/google_update_constants.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/BUILD.gn

diff --git a/chrome/installer/util/BUILD.gn b/chrome/installer/util/BUILD.gn

index ceedefd1ac017675d5e80c1d5fd2a9e3b90f3ef2..fa0b7565d1442104752fa7a3a1c2a69bfbf221c5 100644

--- a/chrome/installer/util/BUILD.gn

+++ b/chrome/installer/util/BUILD.gn

@@ -122,8 +122,6 @@ static_library("util") {

"google_chrome_sxs_distribution.h",

"google_update_constants.cc",

"google_update_constants.h",

- "google_update_experiment_util.cc",

- "google_update_experiment_util.h",

"google_update_settings.cc",

"google_update_settings.h",

"google_update_util.cc",

@@ -167,8 +165,6 @@ static_library("util") {

]

} else {

sources = [

- "google_update_experiment_util.cc",

- "google_update_experiment_util.h",

"master_preferences.cc",

"master_preferences.h",

"master_preferences_constants.cc",

@@ -273,6 +269,7 @@ if (is_win) {

"//chrome:other_version",

"//chrome/common",

"//chrome/installer/test:alternate_version_generator_lib",

+ "//components/variations",

"//content/public/common",

# TODO(rockot): Remove this hack when we fix mojo environment deps.