chrome/installer/util/google_update_constants.h - Issue 1291763002: Componentize kExperimentLabelSeparator & BuildExperimentDateString.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/util/google_update_constants.h

Issue 1291763002: Componentize kExperimentLabelSeparator & BuildExperimentDateString. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move kExperimentLabels to chrome/installer/util/google_update_constants.h (fix Windows build) Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/installer/util/BUILD.gn ('k') | chrome/installer/util/google_update_constants.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Defines all the command-line switches used with Google Update.	5 // Defines all the command-line switches used with Google Update.

6	6

7 #ifndef CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_CONSTANTS_H_	7 #ifndef CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_CONSTANTS_H_

8 #define CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_CONSTANTS_H_	8 #define CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_CONSTANTS_H_

9	9

10 namespace google_update {	10 namespace google_update {

(...skipping 61 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
72 extern const wchar_t kRegRunAsUserField[];	72 extern const wchar_t kRegRunAsUserField[];

73 extern const wchar_t kRegSendsPingsField[];	73 extern const wchar_t kRegSendsPingsField[];

74 extern const wchar_t kRegUninstallCmdLine[];	74 extern const wchar_t kRegUninstallCmdLine[];

75 extern const wchar_t kRegUsageStatsField[];	75 extern const wchar_t kRegUsageStatsField[];

76 extern const wchar_t kRegVersionField[];	76 extern const wchar_t kRegVersionField[];

77 extern const wchar_t kRegWebAccessibleField[];	77 extern const wchar_t kRegWebAccessibleField[];

78	78

79 // last time that chrome ran in the Time internal format.	79 // last time that chrome ran in the Time internal format.

80 extern const wchar_t kRegLastRunTimeField[];	80 extern const wchar_t kRegLastRunTimeField[];

81	81

	82 #if defined(OS_WIN)
	Alexei Svitkine (slow) 2015/08/13 16:52:05 Can you check if this file is already Windows-spec Can you check if this file is already Windows-specific? If so, no need for this ifdef. Ditto for the .cc.
	83 // The name of the value where Google Update reads the list of experiments for

	84 // itself and Chrome.

	85 extern const wchar_t kExperimentLabels[];

	86 #endif

	87

82 } // namespace google_update	88 } // namespace google_update

83	89

84 #endif // CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_CONSTANTS_H_	90 #endif // CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_CONSTANTS_H_

OLD	NEW