Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1291753004: Add onconnect and ondisconnect events to navigator.usb. (Closed)

Created:
5 years, 4 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 4 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add onconnect and ondisconnect events to navigator.usb. This patch updates USB.idl to add these two events, making it an EventTarget. WebUSBClient still needs to be updated to support delivering these events to Blink. BUG=492204 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200912

Patch Set 1 #

Total comments: 1

Patch Set 2 : Check for detached frame. #

Patch Set 3 : Update LayoutTests. #

Messages

Total messages: 16 (7 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 4 months ago (2015-08-19 20:26:33 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 4 months ago (2015-08-19 21:46:26 UTC) #3
Reilly Grant (use Gerrit)
Adding haraken@ for Source/modules/EventTargetModulesFactory.in.
5 years, 4 months ago (2015-08-19 21:48:17 UTC) #5
haraken
LGTM +tkent-san for API owner review on EventTargetModules.in. https://codereview.chromium.org/1291753004/diff/1/Source/modules/webusb/USB.cpp File Source/modules/webusb/USB.cpp (right): https://codereview.chromium.org/1291753004/diff/1/Source/modules/webusb/USB.cpp#newcode114 Source/modules/webusb/USB.cpp:114: return ...
5 years, 4 months ago (2015-08-20 00:31:31 UTC) #7
tkent
API owner review is unnecessary because USB API is not shipped yet. anyway lgtm if ...
5 years, 4 months ago (2015-08-20 00:44:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291753004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291753004/40001
5 years, 4 months ago (2015-08-20 01:24:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/123597)
5 years, 4 months ago (2015-08-20 03:04:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291753004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291753004/40001
5 years, 4 months ago (2015-08-20 16:50:09 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 17:32:59 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200912

Powered by Google App Engine
This is Rietveld 408576698