Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1291733002: Add command to kill stray mojo shell servers so we don't have to remember it (Closed)

Created:
5 years, 4 months ago by etiennej
Modified:
5 years, 4 months ago
Reviewers:
ppi
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add command to kill stray mojo shell servers so we don't have to remember it R=ppi@chromium.org, ppi Committed: https://chromium.googlesource.com/external/mojo/+/9f724011b8a4ea7d3db07e50c2de64d5f3ecf7f2

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M mojo/devtools/common/devtoolslib/http_server.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
etiennej
5 years, 4 months ago (2015-08-12 09:22:14 UTC) #1
ppi
https://codereview.chromium.org/1291733002/diff/1/mojo/devtools/common/devtoolslib/http_server.py File mojo/devtools/common/devtoolslib/http_server.py (right): https://codereview.chromium.org/1291733002/diff/1/mojo/devtools/common/devtoolslib/http_server.py#newcode225 mojo/devtools/common/devtoolslib/http_server.py:225: print (' Run `fuser %d/tcp` to find out which ...
5 years, 4 months ago (2015-08-12 09:24:17 UTC) #2
etiennej
https://codereview.chromium.org/1291733002/diff/1/mojo/devtools/common/devtoolslib/http_server.py File mojo/devtools/common/devtoolslib/http_server.py (right): https://codereview.chromium.org/1291733002/diff/1/mojo/devtools/common/devtoolslib/http_server.py#newcode225 mojo/devtools/common/devtoolslib/http_server.py:225: print (' Run `fuser %d/tcp` to find out which ...
5 years, 4 months ago (2015-08-12 09:25:46 UTC) #3
ppi
lgtm https://codereview.chromium.org/1291733002/diff/20001/mojo/devtools/common/devtoolslib/http_server.py File mojo/devtools/common/devtoolslib/http_server.py (right): https://codereview.chromium.org/1291733002/diff/20001/mojo/devtools/common/devtoolslib/http_server.py#newcode227 mojo/devtools/common/devtoolslib/http_server.py:227: print (' or use `fuser -k %d/tcp` terminate ...
5 years, 4 months ago (2015-08-12 09:29:54 UTC) #4
etiennej
https://codereview.chromium.org/1291733002/diff/20001/mojo/devtools/common/devtoolslib/http_server.py File mojo/devtools/common/devtoolslib/http_server.py (right): https://codereview.chromium.org/1291733002/diff/20001/mojo/devtools/common/devtoolslib/http_server.py#newcode227 mojo/devtools/common/devtoolslib/http_server.py:227: print (' or use `fuser -k %d/tcp` terminate it.' ...
5 years, 4 months ago (2015-08-12 09:30:56 UTC) #5
etiennej
5 years, 4 months ago (2015-08-12 09:31:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
9f724011b8a4ea7d3db07e50c2de64d5f3ecf7f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698