LayoutTests/fast/dom/htmlcollection-non-html.html - Issue 1291723004: Remove all support for <applet> handling in Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/htmlcollection-non-html.html

Issue 1291723004: Remove all support for <applet> handling in Chrome. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/htmlallcollection-enumerated-properties-expected.txt ('k') | LayoutTests/fast/dom/plugin-attributes-enumeration.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/htmlcollection-non-html.html

diff --git a/LayoutTests/fast/dom/htmlcollection-non-html.html b/LayoutTests/fast/dom/htmlcollection-non-html.html

index 37cea385069a88b7d44c3ae49cfdc1240eb163da..b79a4348bcc3daeab902199947c49919ee4baee4 100644

--- a/LayoutTests/fast/dom/htmlcollection-non-html.html

+++ b/LayoutTests/fast/dom/htmlcollection-non-html.html

@@ -2,7 +2,8 @@

<head>

-var elem;

+'use strict';

+var elem, select;

var ns = "http://not-html.test";

function testDocumentProperty(attributeName, elementName, base) {

@@ -21,19 +22,21 @@ function testDocumentProperty(attributeName, elementName, base) {

document.body.removeChild(elem);

}

-function testDocumentPropertyWithAttribute(attributeName, elementName, elementAttributeName, base) {

+function testDocumentPropertyWithAttributes(attributeName, elementName, attributes, base) {

var elem;

if (typeof base == 'undefined')

base = 0;

elem = document.createElementNS(ns, elementName);

- elem.setAttribute(elementAttributeName, "foo");

+ for (let k in attributes)

+ elem.setAttribute(k, attributes[k]);

document.body.appendChild(elem);

shouldBe("document." + attributeName + ".length", base + "");

document.body.removeChild(elem);

elem = document.createElement(elementName);

- elem.setAttribute(elementAttributeName, "foo");

+ for (let k in attributes)

+ elem.setAttribute(k, attributes[k]);

document.body.appendChild(elem);

shouldBe("document." + attributeName + ".length", base + 1 + "");

document.body.removeChild(elem);

@@ -75,15 +78,15 @@ function runTest() {

testDocumentProperty("images", "img");

testDocumentProperty("forms", "form");

- testDocumentProperty("applets", "applet");

+ testDocumentPropertyWithAttributes("applets", "object", {type: "application/x-java-applet"});

testDocumentProperty("embeds", "embed");

// Note that this is run before the final script element on this page is inserted

testDocumentProperty("scripts", "script", 3);

- testDocumentPropertyWithAttribute("links", "a", "href");

- testDocumentPropertyWithAttribute("links", "area", "href");

- testDocumentPropertyWithAttribute("anchors", "a", "name");

+ testDocumentPropertyWithAttributes("links", "a", {href: "foo"});

+ testDocumentPropertyWithAttributes("links", "area", {href: "foo"});

+ testDocumentPropertyWithAttributes("anchors", "a", {name: "foo"});

testElementProperty("map", "areas", "area");

testElementProperty("table", "rows", "tr");