Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1291703008: Rename is_chromeos in chrome/src. (Closed)

Created:
5 years, 4 months ago by Peter Mayo
Modified:
5 years, 3 months ago
Reviewers:
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, hguihot+watch_chromium.org, avayvod+watch_chromium.org, jdduke+watch_chromium.org, yzshen+watch_chromium.org, scheib+watch_chromium.org, yusukes+watch_chromium.org, arv+watch_chromium.org, ben+mojo_chromium.org, miu+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, Matt Giuca, nona+watch_chromium.org, aboxhall+watch_chromium.org, shuchen+watch_chromium.org, chromoting-reviews_chromium.org, jam, abarth-chromium, pvalenzuela+watch_chromium.org, je_julie, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, tdresser+watch_chromium.org, hubbe+watch_chromium.org, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, tapted, jasonroberts+watch_google.com, timvolodine, feature-media-reviews_chromium.org, yuzo+watch_chromium.org, oshima+watch_chromium.org, kalyank, piman+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, maniscalco+watch_chromium.org, hclam+watch_chromium.org, plundblad+watch_chromium.org, tfarina, maxbogue+watch_chromium.org, nektar+watch_chromium.org, Aaron Boodman, plaree+watch_chromium.org, telemetry-reviews_chromium.org, dtseng+watch_chromium.org, darin (slow to review), James Su, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename is_chromeos in chrome/src. is_chromeos does a poor job of distinguishing developer builds of chrome for chromeos for your desktop, and chrome for chromeos on a device (where the runtimes are non local, for example) Split this into use_cros_fe and is_chromeos_os. BUG=519943 TEST=ChromiumOS compiles equivalently.

Patch Set 1 #

Patch Set 2 : rename #

Patch Set 3 : retry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -230 lines) Patch
M BUILD.gn View 1 5 chunks +8 lines, -8 lines 0 comments Download
M apps/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/BUILD.gn View 1 6 chunks +6 lines, -6 lines 0 comments Download
M base/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M breakpad/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M build/config/BUILDCONFIG.gn View 1 11 chunks +24 lines, -9 lines 0 comments Download
M build/config/features.gni View 1 5 chunks +29 lines, -9 lines 0 comments Download
M build/config/linux/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M build/config/sysroot.gni View 1 3 chunks +3 lines, -2 lines 0 comments Download
M build/config/ui.gni View 1 3 chunks +12 lines, -2 lines 0 comments Download
M build/module_args/v8.gni View 1 2 chunks +2 lines, -1 line 0 comments Download
M build/sanitizers/BUILD.gn View 1 1 chunk +3 lines, -1 line 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/BUILD.gn View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/app/resources/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/braille_ime/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_repack_locales.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/schemas.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/variations/BUILD.gn View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 25 chunks +27 lines, -27 lines 0 comments Download
M chrome/third_party/chromevox/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chromeos/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 1 2 chunks +3 lines, -3 lines 0 comments Download
M components/gcm_driver/BUILD.gn View 1 2 chunks +3 lines, -1 line 0 comments Download
M components/metrics/BUILD.gn View 1 2 chunks +3 lines, -1 line 0 comments Download
M components/ownership/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M components/policy/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/core/common/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M components/policy/proto/BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
M components/session_manager/core/BUILD.gn View 1 2 chunks +3 lines, -1 line 0 comments Download
M components/signin/core/browser/BUILD.gn View 1 2 chunks +3 lines, -1 line 0 comments Download
M components/storage_monitor/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M components/user_manager/BUILD.gn View 1 3 chunks +4 lines, -2 lines 0 comments Download
M components/wallpaper/BUILD.gn View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 3 chunks +4 lines, -4 lines 0 comments Download
M content/common/BUILD.gn View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/gpu/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M crypto/BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
M device/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M device/battery/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/BUILD.gn View 1 2 chunks +3 lines, -1 line 0 comments Download
M device/hid/BUILD.gn View 1 2 chunks +3 lines, -1 line 0 comments Download
M device/media_transfer_protocol/BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
M device/nfc/BUILD.gn View 1 2 chunks +3 lines, -1 line 0 comments Download
M device/serial/BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
M device/usb/BUILD.gn View 1 2 chunks +3 lines, -1 line 0 comments Download
M extensions/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/api/schemas.gni View 1 1 chunk +3 lines, -1 line 0 comments Download
M extensions/shell/BUILD.gn View 1 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/shell/common/api/schemas.gni View 1 1 chunk +3 lines, -1 line 0 comments Download
M gpu/gles2_conform_support/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/tools/compositor_model_bench/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M media/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M media/cast/BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
M media/mojo/interfaces/BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
M net/BUILD.gn View 1 7 chunks +7 lines, -7 lines 0 comments Download
M printing/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
M remoting/host/BUILD.gn View 1 4 chunks +5 lines, -5 lines 0 comments Download
M remoting/remoting_enable.gni View 1 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/remoting_host.gni View 1 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/remoting_locales.gni View 1 2 chunks +4 lines, -2 lines 0 comments Download
M skia/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M sync/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sync/tools/BUILD.gn View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/gn/format_test_data/029.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/clear_system_cache/BUILD.gn View 1 1 chunk +14 lines, -11 lines 0 comments Download
M ui/app_list/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/BUILD.gn View 1 6 chunks +9 lines, -9 lines 0 comments Download
M ui/base/ime/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/display/BUILD.gn View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/display/util/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/events/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/resources/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/BUILD.gn View 1 5 chunks +7 lines, -7 lines 0 comments Download
M ui/views_content_client/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Mayo
Dependent on https://codereview.chromium.org/1283313004/
5 years, 4 months ago (2015-08-13 02:20:30 UTC) #1
Peter Mayo
rename
5 years, 4 months ago (2015-08-19 21:26:25 UTC) #2
Peter Mayo
5 years, 4 months ago (2015-08-19 21:27:36 UTC) #3 
retry

Powered by Google App Engine
This is Rietveld 408576698