Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 1291703007: Rename is_chromeos in libexif. (Closed)

Created:
5 years, 4 months ago by Peter Mayo
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename is_chromeos in libexif. is_chromeos does a poor job of distinguishing developer builds of chrome for chromeos for your desktop, and chrome for chromeos on a device (where the runtimes are non local, for example) Split this into is_chromeos_ui and is_chromeos_os. BUG=519943 TEST=ChromiumOS compiles equivalently.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/libexif/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
Peter Mayo
dependent on https://codereview.chromium.org/1283313004/ up[load suggested thestig@ as a reviewer.
5 years, 4 months ago (2015-08-13 01:25:35 UTC) #1
Lei Zhang
5 years, 4 months ago (2015-08-13 19:15:16 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698