Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1291703005: Issue invalidations when squashed layers move later or off of a grouped mapping. (Closed)

Created:
5 years, 4 months ago by chrishtr
Modified:
5 years, 4 months ago
Reviewers:
Stephen Chennney
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Issue invalidations when squashed layers move later or off of a grouped mapping. We were previously missing an invalidation at the old location of a squashed layer. This invalidation is needed only in certain obscure situations. BUG=515901 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200499

Patch Set 1 #

Total comments: 6

Messages

Total messages: 12 (4 generated)
chrishtr
https://codereview.chromium.org/1291703005/diff/1/LayoutTests/compositing/squashing/invalidate-on-grouped-mapping-reorder.html File LayoutTests/compositing/squashing/invalidate-on-grouped-mapping-reorder.html (right): https://codereview.chromium.org/1291703005/diff/1/LayoutTests/compositing/squashing/invalidate-on-grouped-mapping-reorder.html#newcode1 LayoutTests/compositing/squashing/invalidate-on-grouped-mapping-reorder.html:1: <!DOCTYPE html> I tried for a couple of hours, ...
5 years, 4 months ago (2015-08-12 19:29:55 UTC) #2
Stephen Chennney
I'd just like you to give a second thought to the issue that stated all ...
5 years, 4 months ago (2015-08-13 16:31:19 UTC) #3
chrishtr
https://codereview.chromium.org/1291703005/diff/1/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp File Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp (right): https://codereview.chromium.org/1291703005/diff/1/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp#newcode2335 Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp:2335: m_squashedLayers[i].paintLayer->setGroupedMapping(nullptr, DeprecatedPaintLayer::DoNotInvalidateLayerAndRemoveFromMapping); On 2015/08/13 at 16:31:18, Stephen Chenney wrote: ...
5 years, 4 months ago (2015-08-13 17:05:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291703005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291703005/1
5 years, 4 months ago (2015-08-13 17:06:11 UTC) #6
chrishtr
On 2015/08/13 at 17:05:59, chrishtr wrote: > https://codereview.chromium.org/1291703005/diff/1/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp > File Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp (right): > > https://codereview.chromium.org/1291703005/diff/1/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp#newcode2335 ...
5 years, 4 months ago (2015-08-13 17:08:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/92758)
5 years, 4 months ago (2015-08-13 19:32:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291703005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291703005/1
5 years, 4 months ago (2015-08-13 20:01:57 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 22:34:10 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200499

Powered by Google App Engine
This is Rietveld 408576698