Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1291703004: Make inspector-protocol/json-parse.html report an error rather than time out. (Closed)

Created:
5 years, 4 months ago by dgozman
Modified:
5 years, 4 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Make inspector-protocol/json-parse.html report an error rather than time out. BUG=520195 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200432

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M LayoutTests/inspector-protocol/json-parse.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector-protocol/json-parse-expected.txt View 1 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
dgozman
Take a look please.
5 years, 4 months ago (2015-08-12 19:03:26 UTC) #2
yurys
lgtm https://codereview.chromium.org/1291703004/diff/1/LayoutTests/inspector-protocol/json-parse.html File LayoutTests/inspector-protocol/json-parse.html (right): https://codereview.chromium.org/1291703004/diff/1/LayoutTests/inspector-protocol/json-parse.html#newcode13 LayoutTests/inspector-protocol/json-parse.html:13: { Alternatively we could always dump JSON.stringify(msg, null, ...
5 years, 4 months ago (2015-08-12 19:05:42 UTC) #3
dgozman
https://codereview.chromium.org/1291703004/diff/1/LayoutTests/inspector-protocol/json-parse.html File LayoutTests/inspector-protocol/json-parse.html (right): https://codereview.chromium.org/1291703004/diff/1/LayoutTests/inspector-protocol/json-parse.html#newcode13 LayoutTests/inspector-protocol/json-parse.html:13: { On 2015/08/12 19:05:42, yurys wrote: > Alternatively we ...
5 years, 4 months ago (2015-08-12 21:19:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291703004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291703004/20001
5 years, 4 months ago (2015-08-12 21:20:29 UTC) #7
yurys
lgtm, thanks
5 years, 4 months ago (2015-08-12 21:25:07 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 22:25:08 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200432

Powered by Google App Engine
This is Rietveld 408576698