Issue 12917008: Android WebView: actually fix the sdk jar problem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12917008: Android WebView: actually fix the sdk jar problem. (Closed)

Created:
7 years, 9 months ago by Torne

Modified:
7 years, 9 months ago

Reviewers:
bulach, benm (inactive)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android WebView: actually fix the sdk jar problem. r188747 didn't actually fix the webview build problem (though it's still a useful refactoring) - the right fix is just to add quotes to the expansion in java.gypi such that the shell doesn't try to expand make variables. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188760

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	build/java.gypi	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Torne

Committed patchset #1 manually as r188760 (presubmit successful).

7 years, 9 months ago (2013-03-18 17:23:25 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages