Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1291673005: Adding a null pointer check in HTMLCanvasElement::didRecalcStyle (Closed)

Created:
5 years, 4 months ago by Justin Novosad
Modified:
5 years, 4 months ago
Reviewers:
Stephen White
CC:
blink-reviews, dshwang, blink-reviews-html_chromium.org, dglazkov+blink, Rik, Justin Novosad
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Adding a null pointer check in HTMLCanvasElement::didRecalcStyle BUG=520066 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +8 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
Justin Novosad
PTAL
5 years, 4 months ago (2015-08-17 18:09:55 UTC) #2
Stephen White
LGTM
5 years, 4 months ago (2015-08-17 18:40:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291673005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291673005/1
5 years, 4 months ago (2015-08-17 18:41:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99138)
5 years, 4 months ago (2015-08-17 21:17:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291673005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291673005/1
5 years, 4 months ago (2015-08-17 21:36:54 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 21:41:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200673

Powered by Google App Engine
This is Rietveld 408576698