Issue 1291663005: Revert of drawBitmapImage can batch across AA rects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1291663005: Revert of drawBitmapImage can batch across AA rects (Closed)

Created:
5 years, 4 months ago by joshualitt

Modified:
5 years, 4 months ago

Reviewers:
bsalomon, robertphillips, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@gmfordrawimagerect

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of drawBitmapImage can batch across AA rects (patchset #5 id:80001 of https://codereview.chromium.org/1293543002/ ) Reason for revert: a follow up patch exposes a bug Original issue's description: > drawBitmapImage can batch across AA rects > > BUG=464835 > > Committed: https://skia.googlesource.com/skia/+/0d4bcea0d570041434ac3de2df2bd9063138fdb5 TBR=bsalomon@google.com,robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=464835 Committed: https://skia.googlesource.com/skia/+/29553b39bbfe55f2fad9028d5f4e823db7c99c22

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -110 lines)			Patch
	M	src/gpu/SkGpuDevice.cpp	View		4 chunks	+13 lines, -98 lines	0 comments	Download
	M	src/gpu/batches/GrRectBatchFactory.h	View		2 chunks	+4 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

joshualitt

Created Revert of drawBitmapImage can batch across AA rects

5 years, 4 months ago (2015-08-17 14:20:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291663005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291663005/1

5 years, 4 months ago (2015-08-17 14:20:53 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-08-17 14:21:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/29553b39bbfe55f2fad9028d5f4e823db7c99c22

Expand Messages | Collapse Messages