Source/modules/nfc/NFC.h - Issue 1291663004: [webnfc]: Step 1: Add NavigatorNfc, Nfc and Layout tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/nfc/NFC.h

Issue 1291663004: [webnfc]: Step 1: Add NavigatorNfc, Nfc and Layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: name runtime-enabled-features flag as WebNFC; add kenneth as owner Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef NFC_h

	6 #define NFC_h

	7

	8 #include "bindings/core/v8/ScriptPromise.h"

	9 #include "bindings/core/v8/ScriptWrappable.h"

	10 #include "core/dom/ActiveDOMObject.h"

	11 #include "core/frame/DOMWindowProperty.h"

	12 #include "platform/heap/Handle.h"

	13

	14 namespace blink {

	15

	16 class NFC final

	17 : public GarbageCollectedFinalized<NFC>

	18 , public ScriptWrappable

	19 , public ActiveDOMObject

	20 , public DOMWindowProperty {

	21 DEFINE_WRAPPERTYPEINFO();

	22 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(NFC);

	23

	24 public:

	25 NFC(ExecutionContext, LocalFrame);
	Jeffrey Yasskin 2015/08/18 17:48:59 If you only intend to create NFC objects using NFC If you only intend to create NFC objects using NFC::Create, you should make the other constructor private. riju_ 2015/08/19 08:41:22 Done. Show quoted text On 2015/08/18 17:48:59, Jeffrey Yasskin wrote: > If you only intend to create NFC objects using NFC::Create, you should make the > other constructor private. Done.
	26 static NFC* create(ExecutionContext, LocalFrame);

	27 virtual ~NFC();
	Jeffrey Yasskin 2015/08/18 17:48:59 We generally write "~NFC() override;" for overridi We generally write "~NFC() override;" for overriding virtual functions. Although you can just leave this out for now since it's empty. riju_ 2015/08/19 08:41:22 Acknowledged. Show quoted text On 2015/08/18 17:48:59, Jeffrey Yasskin wrote: > We generally write "~NFC() override;" for overriding virtual functions. Although > you can just leave this out for now since it's empty. Acknowledged. Jeffrey Yasskin 2015/08/19 16:40:04 Oh, I meant you can probably delete ~NFC() entirel Show quoted text On 2015/08/19 08:41:22, riju_ wrote: > On 2015/08/18 17:48:59, Jeffrey Yasskin wrote: > > We generally write "~NFC() override;" for overriding virtual functions. > Although > > you can just leave this out for now since it's empty. > > Acknowledged. Oh, I meant you can probably delete ~NFC() entirely. If you keep it, it should be marked override.
	28 ScriptPromise requestAdapter(ScriptState*);
	Jeffrey Yasskin 2015/08/18 17:48:59 Comment which parts of the interface are IDL-expos Comment which parts of the interface are IDL-exposed vs which are for the C++ code. e.g. https://code.google.com/p/chromium/codesearch/#chromium/src/third_party/WebKi... riju_ 2015/08/19 08:41:22 Done. Show quoted text On 2015/08/18 17:48:59, Jeffrey Yasskin wrote: > Comment which parts of the interface are IDL-exposed vs which are for the C++ > code. e.g. > https://code.google.com/p/chromium/codesearch/#chromium/src/third_party/WebKi... Done.
	29 DECLARE_VIRTUAL_TRACE();

	30 };

	31

	32 } // namespace blink

	33

	34 #endif // NFC_h

OLD	NEW

« no previous file with comments | « Source/modules/modules.gypi ('k') | Source/modules/nfc/NFC.cpp » ('j') | Source/modules/nfc/NavigatorNFC.h » ('J')