Source/modules/nfc/NFC.idl - Issue 1291663004: [webnfc]: Step 1: Add NavigatorNfc, Nfc and Layout tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/nfc/NFC.idl

Issue 1291663004: [webnfc]: Step 1: Add NavigatorNfc, Nfc and Layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Nfc->NFC, add owners file, fix haraken's comment to use create() Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://w3c.github.io/web-nfc/#idl-def-NFC

	6

	7 [

	8 GarbageCollected,

	9 ActiveDOMObject,

	10 RuntimeEnabled=Nfc,
	kenneth.r.christiansen 2015/08/18 11:44:13 NFC no? NFC no? riju_ 2015/08/18 11:56:59 Let's keep the flag name as Nfc only. I have not s Show quoted text On 2015/08/18 11:44:13, kenneth.r.christiansen wrote: > NFC no? Let's keep the flag name as Nfc only. I have not seen a flag with all caps. e.g. Bluetooth is using WebBluetooth, would you prefer WebNfc? Mike West 2015/08/18 12:47:21 "XSLT", "SVG1DOM", etc. Show quoted text On 2015/08/18 at 11:56:59, riju_ wrote: > On 2015/08/18 11:44:13, kenneth.r.christiansen wrote: > > NFC no? > > Let's keep the flag name as Nfc only. I have not seen a flag with all caps. "XSLT", "SVG1DOM", etc. Show quoted text > e.g. Bluetooth is using WebBluetooth, would you prefer WebNfc? The spec is named "Web NFC API". I'd suggest that being consistent here by naming the flag "WebNFC" would be reasonable. riju_ 2015/08/18 15:22:12 Sorry missed that. Done. Show quoted text On 2015/08/18 12:47:21, Mike West (traveling) wrote: > On 2015/08/18 at 11:56:59, riju_ wrote: > > On 2015/08/18 11:44:13, kenneth.r.christiansen wrote: > > > NFC no? > > > > Let's keep the flag name as Nfc only. I have not seen a flag with all caps. > > "XSLT", "SVG1DOM", etc. > > > e.g. Bluetooth is using WebBluetooth, would you prefer WebNfc? > > The spec is named "Web NFC API". I'd suggest that being consistent here by > naming the flag "WebNFC" would be reasonable. Sorry missed that. Done.
	11 ] interface NFC {

	12 [CallWith=ScriptState] Promise<NFCAdapter> requestAdapter ();

	13 };

OLD	NEW

« no previous file with comments | « Source/modules/nfc/NFC.cpp ('k') | Source/modules/nfc/NavigatorNFC.h » ('j') | no next file with comments »