Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1291643002: Revert of Move NumberOfPlanesForGpuMemoryBufferFormat to gfx (Closed)

Created:
5 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move NumberOfPlanesForGpuMemoryBufferFormat to gfx (patchset #4 id:120001 of https://codereview.chromium.org/1281043006/ ) Reason for revert: This breaks Win 64 builds: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN Original issue's description: > Move NumberOfPlanesForGpuMemoryBufferFormat to gfx > > We will need to call it from media::GpuMemoryBufferVideoFramePool when we > add support for YUV_420_BIPLANAR. > > BUG=510260 > TEST=No behavior change, only moving code. > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/85f29861d095a7c5dcf318053e8349d1efaddbab > Cr-Commit-Position: refs/heads/master@{#342942} TBR=reveman@chromium.org,ccameron@chromium.org,msw@chromium.org,jbauman@chromium.org,avi@chromium.org,andresantoso@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510260 Committed: https://crrev.com/ccc61032355c3198efa69f388b84cf2f5548041b Cr-Commit-Position: refs/heads/master@{#342948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -82 lines) Patch
M cc/test/test_gpu_memory_buffer_manager.cc View 4 chunks +23 lines, -6 lines 0 comments Download
M components/view_manager/gles2/mojo_gpu_memory_buffer.cc View 4 chunks +23 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/child/child_thread_impl_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl.cc View 3 chunks +23 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 5 chunks +23 lines, -4 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/gfx/buffer_format_util.h View 1 chunk +0 lines, -19 lines 0 comments Download
D ui/gfx/buffer_format_util.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Rockot(use gerrit already)
Created Revert of Move NumberOfPlanesForGpuMemoryBufferFormat to gfx
5 years, 4 months ago (2015-08-12 00:39:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291643002/1
5 years, 4 months ago (2015-08-12 00:39:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-12 00:40:43 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 00:41:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccc61032355c3198efa69f388b84cf2f5548041b
Cr-Commit-Position: refs/heads/master@{#342948}

Powered by Google App Engine
This is Rietveld 408576698