Remove STATIC_CONST_MEMBER_DEFINITION.

Remove STATIC_CONST_MEMBER_DEFINITION.

There's a single client of it, and that client becomes shorter by not using
this. Also see discussion on https://codereview.chromium.org/60103005/
and thread "[chromium-dev] Style question: static const members vs enums"

BUG=none

Committed: https://crrev.com/24b0507394153b44923e8bd82d18859c97dc690d
Cr-Commit-Position: refs/heads/master@{#343102}

[Nico, 2015-08-12 17:23:34]

thakis@chromium.org changed reviewers:
+ danakj@chromium.org

[Nico, 2015-08-12 17:23:34]

dank cl, yo

[danakj, 2015-08-12 17:47:20]

LGTM

https://codereview.chromium.org/1291623002/diff/20001/base/compiler_specific.h
File base/compiler_specific.h (right):

https://codereview.chromium.org/1291623002/diff/20001/base/compiler_specific....
base/compiler_specific.h:71: // The C++ standard requires that static const
members have an out-of-class
you missed this line?

[Nico, 2015-08-12 17:55:42]

https://codereview.chromium.org/1291623002/diff/20001/base/compiler_specific.h
File base/compiler_specific.h (right):

https://codereview.chromium.org/1291623002/diff/20001/base/compiler_specific....
base/compiler_specific.h:71: // The C++ standard requires that static const
members have an out-of-class
On 2015/08/12 17:47:20, danakj wrote:
> you missed this line?

Done.

[Nico, 2015-08-12 17:55:45]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-08-12 17:55:46]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1291623002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2015-08-12 17:56:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1291623002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1291623002/40001

[commit-bot: I haz the power, 2015-08-12 18:05:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-12 18:05:55]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2015-08-12 18:08:15]

thakis@chromium.org changed reviewers:
+ avi@chromium.org

[Nico, 2015-08-12 18:08:15]

avi: content/ pls

[Avi (use Gerrit), 2015-08-12 19:59:10]

lgtm

[Avi (use Gerrit), 2015-08-12 19:59:19]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2015-08-12 19:59:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1291623002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1291623002/40001

[commit-bot: I haz the power, 2015-08-12 21:51:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-12 21:51:40]

Patchset 3 (id:??) landed as
https://crrev.com/24b0507394153b44923e8bd82d18859c97dc690d
Cr-Commit-Position: refs/heads/master@{#343102}