Add check for executable stack/heap when rating Linux exploitability.

Add check for executable stack/heap when rating Linux exploitability.

This CL also consequentially adds a public method to get the number of
mappings in a Linux minidump.

R=ivanpe@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1488

[liuandrew, 2015-08-12 00:08:57]

liu.andrew.x@gmail.com changed reviewers:
+ ahonig@google.com, ivanpe@chromium.org

[ivanpe, 2015-08-12 00:26:24]

https://codereview.chromium.org/1291603002/diff/1/src/google_breakpad/process...
File src/google_breakpad/processor/minidump.h (right):

https://codereview.chromium.org/1291603002/diff/1/src/google_breakpad/process...
src/google_breakpad/processor/minidump.h:918: unsigned int mapping_count() const
{ return valid_ ? maps_count_ : 0; }
Getter should match the name of the variable:
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Names

https://codereview.chromium.org/1291603002/diff/1/src/processor/exploitabilit...
File src/processor/exploitability_linux.cc (right):

https://codereview.chromium.org/1291603002/diff/1/src/processor/exploitabilit...
src/processor/exploitability_linux.cc:133: const MinidumpLinuxMaps *linux_maps =
linux_maps_list->GetLinuxMapsAtIndex(i);
Lines should not exceed 80 chars

https://codereview.chromium.org/1291603002/diff/1/src/processor/exploitabilit...
src/processor/exploitability_linux.cc:143: return false;
Please add a unittest for this method.

https://codereview.chromium.org/1291603002/diff/1/src/processor/exploitabilit...
File src/processor/exploitability_linux.h (right):

https://codereview.chromium.org/1291603002/diff/1/src/processor/exploitabilit...
src/processor/exploitability_linux.h:62: // This method checks if the stack or
heap are marked executable according
optional: you may want to remove "This method " from the description of this
method and the other two above it.

[liuandrew, 2015-08-14 22:43:36]

Uploaded patch set 2.

Changes include:
 - unittests
 - other miscellanous changes

https://codereview.chromium.org/1291603002/diff/1/src/google_breakpad/process...
File src/google_breakpad/processor/minidump.h (right):

https://codereview.chromium.org/1291603002/diff/1/src/google_breakpad/process...
src/google_breakpad/processor/minidump.h:918: unsigned int mapping_count() const
{ return valid_ ? maps_count_ : 0; }
On 2015/08/12 00:26:23, ivanpe wrote:
> Getter should match the name of the variable:
>
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Names

Done.

https://codereview.chromium.org/1291603002/diff/1/src/processor/exploitabilit...
File src/processor/exploitability_linux.cc (right):

https://codereview.chromium.org/1291603002/diff/1/src/processor/exploitabilit...
src/processor/exploitability_linux.cc:133: const MinidumpLinuxMaps *linux_maps =
linux_maps_list->GetLinuxMapsAtIndex(i);
On 2015/08/12 00:26:23, ivanpe wrote:
> Lines should not exceed 80 chars

Done.

https://codereview.chromium.org/1291603002/diff/1/src/processor/exploitabilit...
src/processor/exploitability_linux.cc:143: return false;
On 2015/08/12 00:26:23, ivanpe wrote:
> Please add a unittest for this method.

Done.

https://codereview.chromium.org/1291603002/diff/1/src/processor/exploitabilit...
File src/processor/exploitability_linux.h (right):

https://codereview.chromium.org/1291603002/diff/1/src/processor/exploitabilit...
src/processor/exploitability_linux.h:62: // This method checks if the stack or
heap are marked executable according
On 2015/08/12 00:26:23, ivanpe wrote:
> optional: you may want to remove "This method " from the description of this
> method and the other two above it.

Done.

[ivanpe, 2015-08-14 23:11:46]

lgtm

[liuandrew, 2015-08-15 00:37:22]

Committed patchset #3 (id:40001) manually as r1488 (presubmit successful).