src/objects.cc - Issue 12916005: Add instrumentation to track down Code::CopyFrom crasher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 12916005: Add instrumentation to track down Code::CopyFrom crasher. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 5c33aafbacaf759189f05f6fe57e878625eea9aa..9b7e0a76c3948ebcdf0ffe59856f997bd12bde39 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -8816,6 +8816,8 @@ void Code::CopyFrom(const CodeDesc& desc) {

memmove(instruction_start(), desc.buffer, desc.instr_size);

// copy reloc info

+ // TODO(mstarzinger): Remove once we found the bug.

+ CHECK(relocation_info()->IsByteArray());

memmove(relocation_start(),

desc.buffer + desc.buffer_size - desc.reloc_size,

desc.reloc_size);

« no previous file with comments | « src/heap.cc ('k') | no next file » | no next file with comments »